From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 12 Dec 2013 18:04:43 +0000 Subject: Re: [PATCH] ARM: shmobile: Add select MIGHT_HAVE_PCI for PCI-AHB bridge code Message-Id: <52AA08C5.3050402@cogentembedded.com> List-Id: References: <1386870969-22241-1-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1386870969-22241-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 12/12/2013 08:56 PM, Ben Dooks wrote: > The PCI sub-system is not enabled by default on ARM and on certain > Renesas devices the build does not select it. This means that there > are configurations that do not allow the AHB-PCI bridge used for the > USB sub-systems to be built. > For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the > PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config > where there may be many Reneasas devices selected. > Cc: Simon Horman > Cc: Magnus Damm > CC: Linux SH List > Reviewed-by: Ian Molton > Signed-off-by: Ben Dooks > --- > arch/arm/mach-shmobile/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > index 3e57d45..010d2a6 100644 > --- a/arch/arm/mach-shmobile/Kconfig > +++ b/arch/arm/mach-shmobile/Kconfig [...] > @@ -101,6 +102,7 @@ config ARCH_R8A7779 > select ARCH_WANT_OPTIONAL_GPIOLIB > select ARM_GIC > select CPU_V7 > + select MIGHT_HAVE_PCI > select SH_CLK_CPG > select USB_ARCH_HAS_EHCI > select USB_ARCH_HAS_OHCI Er, this is R8A7779 section. This SoC doesn't have PCI-AHB bridge. > @@ -111,6 +113,7 @@ config ARCH_R8A7790 > select ARCH_WANT_OPTIONAL_GPIOLIB > select ARM_GIC > select CPU_V7 > + select MIGHT_HAVE_PCI > select SH_CLK_CPG > select RENESAS_IRQC > R8A7791 section is contrarywise missing. BTW, there's stray letter 'c' before that section. WBR, Sergei