Re: [Qemu-devel] [PATCH v12 1/5] vmstate: Add support for an array of ptimer_state *

[Li Guang <lig.fnst@cn.fujitsu.com>]

Peter Crosthwaite wrote:
> On Fri, Dec 13, 2013 at 11:19 AM, liguang<lig.fnst@cn.fujitsu.com>  wrote:
>    
>> From: Peter Maydell<peter.maydell@linaro.org>
>>
>> Add support for defining a vmstate field which is an array
>> of pointers to structures, and use this to define a
>> VMSTATE_PTIMER_ARRAY() which allows an array of ptimer_state*
>> to be used by devices.
>>
>> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>>      
> If you are intending someones else patch for merge as part of your own
> series, you should sign it off yourself. Considering it's only one
> patch, you probably can just do this on list (just like a review)
> rather than a respin.
>
>    

Ok, here's a

Signed-off-by: liguang<lig.fnst@cn.fujitsu.com>

Thanks!



> Regards,
> Peter
>
>    
>> ---
>>   include/hw/ptimer.h         |    4 ++++
>>   include/migration/vmstate.h |   10 ++++++++++
>>   2 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
>> index 28fcaf1..a33edf4 100644
>> --- a/include/hw/ptimer.h
>> +++ b/include/hw/ptimer.h
>> @@ -36,4 +36,8 @@ extern const VMStateDescription vmstate_ptimer;
>>       .offset     = vmstate_offset_pointer(_state, _field, ptimer_state), \
>>   }
>>
>> +#define VMSTATE_PTIMER_ARRAY(_f, _s, _n)                                \
>> +    VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, 0,                   \
>> +                                       vmstate_ptimer, ptimer_state)
>> +
>>   #endif
>> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
>> index 9d09e60..be193ba 100644
>> --- a/include/migration/vmstate.h
>> +++ b/include/migration/vmstate.h
>> @@ -339,6 +339,16 @@ extern const VMStateInfo vmstate_info_bitmap;
>>       .offset     = vmstate_offset_array(_state, _field, _type, _num), \
>>   }
>>
>> +#define VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, _v, _vmsd, _type) { \
>> +    .name       = (stringify(_f)),                                   \
>> +    .version_id = (_v),                                              \
>> +    .num        = (_n),                                              \
>> +    .vmsd       =&(_vmsd),                                          \
>> +    .size       = sizeof(_type *),                                    \
>> +    .flags      = VMS_ARRAY|VMS_STRUCT|VMS_ARRAY_OF_POINTER,         \
>> +    .offset     = vmstate_offset_array(_s, _f, _type*, _n),          \
>> +}
>> +
>>   #define VMSTATE_STRUCT_ARRAY_TEST(_field, _state, _num, _test, _version, _vmsd, _type) { \
>>       .name         = (stringify(_field)),                             \
>>       .num          = (_num),                                          \
>> --
>> 1.7.2.5
>>
>>
>>      
>
>