From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] pv/pvh: disable MTRR feature on cpuid for
	Dom0
Date: Fri, 13 Dec 2013 12:55:51 +0100
Message-ID: <52AAF5C7.1040408@citrix.com>
References: <1386867141-11581-1-git-send-email-roger.pau@citrix.com>
	<52AAFD77020000780010CF49@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1VrRLY-0002qj-OW
	for xen-devel@lists.xenproject.org; Fri, 13 Dec 2013 11:55:56 +0000
In-Reply-To: <52AAFD77020000780010CF49@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/12/13 12:28, Jan Beulich wrote:
>>>> On 12.12.13 at 17:52, Roger Pau Monne <roger.pau@citrix.com> wrote:
>> MTRR is not available for PV/PVH Dom0, so prevent cpuid from
>> reporting it as an available feature.
> 
> Some misunderstanding perhaps? PV certainly has MTRR support for
> Dom0 - see XENPF_*_memtype.

OK, my bad, I was looking for a PV implementation of struct mtrr_ops in
the pvops kernel, but Linux pvops doesn't use MTRR at all, also none of
the XENPF_*_memtype ops seem to be used.

>
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -796,6 +796,7 @@ void pv_cpuid(struct cpu_user_regs *regs)
>>          __clear_bit(X86_FEATURE_DS, &d);
>>          __clear_bit(X86_FEATURE_ACC, &d);
>>          __clear_bit(X86_FEATURE_PBE, &d);
>> +        __clear_bit(X86_FEATURE_MTRR, &d);
> 
> Thus clearing this flag should be limited to PVH.

Will resend now with this fixed, thanks.

Roger.