Re: [PATCH] ASoC: tlv320aic3x: Correct S24_3LE support

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

On 12/13/2013 03:04 PM, Mark Brown wrote:
> On Fri, Dec 13, 2013 at 02:58:19PM +0200, Peter Ujfalusi wrote:
> 
>> -	case SNDRV_PCM_FORMAT_S24_LE:
>> +	case SNDRV_PCM_FORMAT_S24_3LE:
>>  		data |= (0x02 << 4);
>>  		break;
> 
> This should be adding the case for the new format rather than replacing
> the old one shouldn't it?  They ought to turn out the same on the AIF so
> the CODECs shouldn't care about the difference, ideally the core would
> hide the difference from them.

Not really since the codec has only field to specify the data format. The
codec can not support S24_LE (S24_LE is basically S32_LE msbits==24) since we
can not say to the codec to ignore the 8bit over the 24 bits of real data.
In case of S24_3LE the I2S bus will have 24 clocks/per channel which can not
be used to stream S24_LE either.

-- 
Péter