From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrSpn-0001Oo-Lj for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrSpi-0004Mn-5b for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:31:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrSph-0004MX-Tf for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:31:10 -0500 Message-ID: <52AB0C17.8020704@redhat.com> Date: Fri, 13 Dec 2013 06:31:03 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1384307094-5836-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1384307094-5836-3-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uds3dfqJcxFaXPHLV8detq1OoNMhaknvf" Subject: Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uds3dfqJcxFaXPHLV8detq1OoNMhaknvf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/12/2013 06:44 PM, Wenchao Xia wrote: > Nested structure is not supported now, so following define is not valid= : > { 'event': 'EVENT_C', > 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' } But what IS valid? You need to document this in docs/qapi-code-gen.txt at a bare minimum. This patch series is hard to review, and still has the RFC subject line. At this point, I think it's worth rebasing and resending what you have; even if it needs more review, it will at least get it to a state that is easier to review. > +++ b/scripts/qapi-event.py > @@ -0,0 +1,355 @@ > +# > +# QAPI event generator > +# > +# Copyright IBM, Corp. 2013 > +# > +# Authors: > +# Wenchao Xia > +# > +# This work is licensed under the terms of the GNU GPLv2. Can you please use GPLv2+ (that is, add the "or later" clause)? We already have GPLv2-only code, but I don't want to increase the size of that unfortunate license choice. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uds3dfqJcxFaXPHLV8detq1OoNMhaknvf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqwwXAAoJEKeha0olJ0NqLcwH/3tt19pYYvnEjtMM3lybtnqq KT1k8ZRsrZlbLBt0EFg2sfao1aUie6xBgMWtSjH0ZHLlSb7JJ0xM6fY2TEZMYpSX MMt9ZYx6pImROmsLLb+njPTT2NfYCHKjOejTZ3xS2SBL1zaqNRQ+fzKNCKJhlPIL 2tObmbqfz/N15RIxlzgburB06lckE/N2uuSHElYUq/A3vY5A84ySu601jHaAhN+B g7sYykUcm3AE7CcJ1gzLD95UuBzHlDfxrIK+FfHoGjE+HAdBVEj2GQTOi6gulugc 7hhmQ5Lzfsc+1Ac2pEfcxbIsJMn5JjNYjM1/SdHRgb9c34dlwg1y03YHiPjt2u0= =EO6h -----END PGP SIGNATURE----- --uds3dfqJcxFaXPHLV8detq1OoNMhaknvf--