Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

On 12/08/2013 08:43 PM, Wenchao Xia wrote:
>>>
>>> convert -s snapshot.name=name1
>>>
>>    Previous I planned to use -l for internal snapshot in all possible
>> program, since -s is taken as external snapshot in qemu, qemu-nbd.

Consistency in command line options between different tools is nice, but
is less important than adding functionality.  I'm perfectly fine if we
use -l in one tool and -s in another, as long as the documentation is
clear on how to spell the option for the tool I want to use.

>> let -s stands for internal in qemu-img convert only, may bring
>> confuse to user, so I deprecated it instead of enhance it(I want
>> to remove it but may bring compatiablity issue).
>>    Yes, it should report error when both specified, will send a patch
>> if you agree '-l' should still be used.
>>
>>
>   Eric, I hope to get your idea before patching, any comments?
> 

My biggest concern was that by adding -l as a superset of -s, but not
taking care of the relation between the two, you created odd command
line usage patterns.  For qemu-img, it may be simpler to just make -s do
everything, instead of trying to deprecate it (that is, adding -l for
consistency with other tools while breaking -s isn't nice).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]