From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] evtchn/fifo: map correct pages when guest
 is HVM
Date: Fri, 13 Dec 2013 15:14:01 +0000
Message-ID: <52AB2439.8030305@citrix.com>
References: <1386946193-8147-1-git-send-email-david.vrabel@citrix.com>
	<20131213151052.GA5094@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20131213151052.GA5094@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: boris.ostrovsky@oracle.com, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 13/12/13 15:10, Konrad Rzeszutek Wilk wrote:
> On Fri, Dec 13, 2013 at 02:49:53PM +0000, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> If a HVM guest attempts to use the FIFO-based ABI it will not receive
>> any events and destroying the guest may crash Xen or trigger an assert
>> when attempting to unmap a control block page.  This occurs because
>> Xen maps the wrong page for both the control blocks and the event
>> arrays.
>>
>> In map_guest_page(), use the MFN of the guest's page and not the GFN
>> when calling map_domain_page_global().
>>
> 
> Should you have the Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> flag?

Yes. I'm really bad at remembering these.

David