From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888 Date: Fri, 13 Dec 2013 14:58:50 -0800 Message-ID: <52AB912A.1010403@whitecape.org> References: <1385093524-22276-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385093524-22276-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces@lists.freedesktop.org Errors-To: mesa-dev-bounces@lists.freedesktop.org To: Keith Packard , mesa-dev@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 11/21/2013 08:12 PM, Keith Packard wrote: > The __DRIimage createImageFromFds function takes a fourcc code, but there was > no fourcc code that match __DRI_IMAGE_FORMAT_SARGB8. This adds a define for > that format, adds a translation in DRI3 from __DRI_IMAGE_FORMAT_SARGB8 to > __DRI_IMAGE_FOURCC_SARGB8888 and then adds translations *back* to > __IMAGE_FORMAT_SARGB8 in both the i915 and i965 drivers. > > I'll refrain from comments on whether I think having two separate sets of > format defines in dri_interface.h is a good idea or not... > > Signed-off-by: Keith Packard > --- > > This gets iceweasel running with the GL compositor enabled. I see a huge discussion about this patch, but it's not obvious to me whether there were actual concerns or just people asking questions. I see that Eric reviewed it, and that it has not landed. Are there any objections to merging it? --Ken