From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign Date: Sat, 14 Dec 2013 00:00:52 +0000 Message-ID: <52AB9FB4.9060100@linaro.org> References: <1386963461-6520-1-git-send-email-julien.grall@linaro.org> <1386963461-6520-2-git-send-email-julien.grall@linaro.org> <1386976760.20787.89.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VrcfB-0005ck-Uq for xen-devel@lists.xenproject.org; Sat, 14 Dec 2013 00:00:58 +0000 Received: by mail-wg0-f45.google.com with SMTP id y10so2580249wgg.24 for ; Fri, 13 Dec 2013 16:00:55 -0800 (PST) In-Reply-To: <1386976760.20787.89.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , patches@linaro.org, George Dunlap , tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 12/13/2013 11:19 PM, Ian Campbell wrote: > On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote: >> From: Mukesh Rathor >> >> In this patch, a new type p2m_map_foreign is introduced for pages >> that toolstack on PVH dom0 maps from foreign domains that its creating >> or supporting during it's run time. >> >> Signed-off-by: Mukesh Rathor >> Cc: Jan Beulich >> Cc: Keir Fraser >> Cc: George Dunlap >> >> --- >> Changes in v4: >> - Use the patch #4 from dom0 pvh v6 series. We need it for ARM > > Is this really the right patch? I'd have thought it would need to > include some generic/!x86 bits but: This patch introduce p2m_map_foreign type. I think it's safe to push it without the other patches. Moreover, it will avoid dummy #define p2m_is_foreign in my patch #8. > >> --- >> xen/arch/x86/mm/p2m-ept.c | 1 + >> xen/arch/x86/mm/p2m-pt.c | 1 + >> xen/arch/x86/mm/p2m.c | 28 ++++++++++++++++++++-------- >> xen/include/asm-x86/p2m.h | 4 ++++ >> 4 files changed, 26 insertions(+), 8 deletions(-) > > Don't you want patch #6 from the PVH series instead? I made a mistake in my cover letter. I was talking about patch #6 not #7. I have taken the common code in merge into my patch #8. -- Julien Grall