All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenneth Graunke <kenneth@whitecape.org>
To: Emil Velikov <emil.l.velikov@gmail.com>,
	Keith Packard <keithp@keithp.com>,
	mesa-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Don't use libudev for glx/dri3
Date: Fri, 13 Dec 2013 18:33:09 -0800	[thread overview]
Message-ID: <52ABC365.1010001@whitecape.org> (raw)
In-Reply-To: <528A7F6B.3020905@gmail.com>

On 11/18/2013 12:58 PM, Emil Velikov wrote:
> On 18/11/13 01:08, Keith Packard wrote:
>> libudev doesn't have a stable API/ABI, and if the application wants to use one
>> version, we'd best not load another into libGL.
>>
>> Signed-off-by: Keith Packard <keithp@keithp.com>
>> ---
>>
> Hi Keith,
> 
> Did you had the chance to look at src/gallium/targets/egl-static/egl.c?
> It has a different implementation of drm_fd_get_pci_id, whenever udev is
> not available.
> 
> AFAICS it goes back to the kernel via the relevant ioctl to retrieve the
> deviceid/chipid. Currently all but nouveau provide such information. I'm
> thinking that this approach might be more reasonable for those concerned
> with portability of the udev bits (think on *BSD).
> 
> I'm not nitpicking, just thought you might find this interesting.
> 
> Cheers,
> Emil

Possibly.  But looking at that code, it either:
1. Uses libudev
2. On Android only...strcmps the driver string to guess the family and
then uses kernel ioctls...
3. Fails.

The Android only nature makes me a bit wary.

  parent reply	other threads:[~2013-12-14  2:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18  0:55 [PATCH] Don't use libudev for glx/dri3 Keith Packard
2013-11-18  1:08 ` Keith Packard
2013-11-18  1:31   ` Emil Velikov
2013-11-18  2:43     ` Keith Packard
2013-11-18  4:08       ` Kenneth Graunke
2013-11-18  6:03         ` Keith Packard
2013-11-18 21:59       ` Ian Romanick
2013-11-18 20:58   ` Emil Velikov
2013-11-19  6:46     ` Keith Packard
2013-12-14  2:33     ` Kenneth Graunke [this message]
2013-12-14 10:37       ` [Mesa-dev] " Daniel Vetter
2013-12-16 19:19         ` Eric Anholt
2013-12-16 19:57           ` [Mesa-dev] " Daniel Vetter
2013-11-19 18:41   ` Eric Anholt
2013-11-19 19:41     ` Keith Packard
2013-11-19 20:19       ` [Mesa-dev] " Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52ABC365.1010001@whitecape.org \
    --to=kenneth@whitecape.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=keithp@keithp.com \
    --cc=mesa-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.