From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sat, 14 Dec 2013 19:50:13 +0000 Subject: Re: [lm-sensors] [PATCH 00/12] i8k patch series Message-Id: <52ACB675.6060304@roeck-us.net> List-Id: References: <1387042221-3671-1-git-send-email-linux@roeck-us.net> <201312141945.20348.arnd@arndb.de> <20131214200309.3a2007f4@endymion.delvare> In-Reply-To: <20131214200309.3a2007f4@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Delvare , Arnd Bergmann Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Matthew Garrett , "platform-driver-x86@vger.kernel.org" On 12/14/2013 11:03 AM, Jean Delvare wrote: > On Sat, 14 Dec 2013 19:45:19 +0100, Arnd Bergmann wrote: >> On Saturday 14 December 2013, Guenter Roeck wrote: >>> Clean up and simplify the driver, add support for additional temperature >>> sensors, fix a problem seen with multi-core CPU, and add support >>> for additional systems. >>> >>> ---------------------------------------------------------------- >>> Guenter Roeck (14): >>> i8k: Convert to use pr_ functions instead of printk >>> i8k: Fix various checkpatch warnings and errors >>> i8k: Convert to use to hwmon_device_register_with_groups hwmon API >>> i8k: Support additional temperature sensors >>> MAINTAINERS: Add myself as i8k maintainer >>> i8k: Remove obsolete link to out-of-tree driver >>> i8k: Drop driver version number and info message at startup >>> i8k: Force SMM to run on CPU 0 >>> i8k: Add copyright >>> i8k: Add support for Dell Studio laptops >>> i8k: Add support for Dell XPS M140 >>> i8k: Use driver_data field of dmi_system_id to override fan multiplier >>> i8k: Stop reading SMM BIOS version during driver probe >>> i8k: Implement hwmon based fan speed control >>> >>> MAINTAINERS | 2 +- >>> drivers/char/i8k.c | 358 +++++++++++++++++++++++++++++----------------------- >>> 2 files changed, 201 insertions(+), 159 deletions(-) >>> >> >> All changes in this patch set look good to me. >> >> Acked-by: Arnd Bergmann >> >> I wonder if it makes sense to move the driver to drivers/platform/x86/, which >> has a bunch of similar ones already. > > That would be a good idea IMHO. > I agree; drivers/char doesn't seem to be a good location. Guess it is mostly historic that it is there in the first place. Maybe it can even use the API provided by the dell-laptop driver if I can ever figure out how that works. Copying the platform-x86 mailing list and Matthew for additional input. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [lm-sensors] [PATCH 00/12] i8k patch series Date: Sat, 14 Dec 2013 11:50:13 -0800 Message-ID: <52ACB675.6060304@roeck-us.net> References: <1387042221-3671-1-git-send-email-linux@roeck-us.net> <201312141945.20348.arnd@arndb.de> <20131214200309.3a2007f4@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.active-venture.com ([67.228.131.205]:61217 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954Ab3LNTuQ (ORCPT ); Sat, 14 Dec 2013 14:50:16 -0500 In-Reply-To: <20131214200309.3a2007f4@endymion.delvare> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Jean Delvare , Arnd Bergmann Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Matthew Garrett , "platform-driver-x86@vger.kernel.org" On 12/14/2013 11:03 AM, Jean Delvare wrote: > On Sat, 14 Dec 2013 19:45:19 +0100, Arnd Bergmann wrote: >> On Saturday 14 December 2013, Guenter Roeck wrote: >>> Clean up and simplify the driver, add support for additional temperature >>> sensors, fix a problem seen with multi-core CPU, and add support >>> for additional systems. >>> >>> ---------------------------------------------------------------- >>> Guenter Roeck (14): >>> i8k: Convert to use pr_ functions instead of printk >>> i8k: Fix various checkpatch warnings and errors >>> i8k: Convert to use to hwmon_device_register_with_groups hwmon API >>> i8k: Support additional temperature sensors >>> MAINTAINERS: Add myself as i8k maintainer >>> i8k: Remove obsolete link to out-of-tree driver >>> i8k: Drop driver version number and info message at startup >>> i8k: Force SMM to run on CPU 0 >>> i8k: Add copyright >>> i8k: Add support for Dell Studio laptops >>> i8k: Add support for Dell XPS M140 >>> i8k: Use driver_data field of dmi_system_id to override fan multiplier >>> i8k: Stop reading SMM BIOS version during driver probe >>> i8k: Implement hwmon based fan speed control >>> >>> MAINTAINERS | 2 +- >>> drivers/char/i8k.c | 358 +++++++++++++++++++++++++++++----------------------- >>> 2 files changed, 201 insertions(+), 159 deletions(-) >>> >> >> All changes in this patch set look good to me. >> >> Acked-by: Arnd Bergmann >> >> I wonder if it makes sense to move the driver to drivers/platform/x86/, which >> has a bunch of similar ones already. > > That would be a good idea IMHO. > I agree; drivers/char doesn't seem to be a good location. Guess it is mostly historic that it is there in the first place. Maybe it can even use the API provided by the dell-laptop driver if I can ever figure out how that works. Copying the platform-x86 mailing list and Matthew for additional input. Thanks, Guenter