From: Mark Lord <mlord@pobox.com>
To: jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Recent change to hid-core.c
Date: Sun, 15 Dec 2013 00:26:12 -0500 [thread overview]
Message-ID: <52AD3D74.90905@pobox.com> (raw)
Jiri,
The recent update 08ec2dcc3527a20c619aca2fb36f800908256bac
"Merge branches 'for-3.11/multitouch', 'for-3.11/sony' and 'for-3.11/upstream' into for-linus"
included an unexpected change to the return code handing for ->raw_event() calls.
A HID driver's raw_event() method previously could return these values:
0 --> keep processing.
1 --> no further processing required.
<0 --> error.
Now, "1" and "0" are both treated as "keep processing",
so a lower level HID driver has to return a negative error code
to achieve the "no further processing required" state.
Was this intentional? Doesn't that have side-effects for some drivers?
Thanks
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
next reply other threads:[~2013-12-15 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 5:26 Mark Lord [this message]
2013-12-16 13:24 ` Recent change to hid-core.c Jiri Kosina
2013-12-16 14:52 ` Mark Lord
2013-12-16 14:56 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AD3D74.90905@pobox.com \
--to=mlord@pobox.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.