From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Taras Kondratiuk <taras.kondratiuk@linaro.org>
Subject: Re: [PATCH v7] gpio: davinci: use {readl|writel}_relaxed() instead of __raw_*
Date: Sun, 15 Dec 2013 17:05:46 +0530 [thread overview]
Message-ID: <52AD9412.1010508@ti.com> (raw)
In-Reply-To: <CA+V-a8sFpMJce19o9USBFzG2qnxtUrfdLVKPi8em6RnYA5Tfuw@mail.gmail.com>
On Friday 13 December 2013 09:34 AM, Prabhakar Lad wrote:
> Hi Linus,
>
> On Fri, Dec 13, 2013 at 2:01 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Wed, Dec 11, 2013 at 6:52 PM, Prabhakar Lad
>> <prabhakar.csengg@gmail.com> wrote:
>>
>>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>>
>>> This patch replaces the __raw_readl/writel with
>>> {readl|writel}_relaxed(), Altough the code runs on ARMv5
>>> based SOCs, changing this will help copying the code
s/copying/using
>>> for other uses.
Call out usability on big-endian machines specifically here.
>>>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>> ---
>>> This patch is part of series [1] rest of the patches
>>> are Acked/reviewed so posting this patch independently
>>> and marking it as v7.
>>>
>>> [1] http://www.spinics.net/lists/devicetree/msg13037.html
>>>
>>> drivers/gpio/gpio-davinci.c | 36 ++++++++++++++++++------------------
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
> Thanks for the Ack.
>
>> Should I take this into the GPIO tree, or should it go
>> in through the DaVinci tree?
>>
> To avoid dependencies its better it goes via DaVinci tree.
I added this to v3.14/gpio branch of my tree (with modifications I
mentioned above).
I dont think there are dependencies for this particular patch though
(applies and builds nicely on latest Linus T's tree). Even then, there
are too many GPIO patches floating around and I think it is better for
me to collect them for a while and if there really are no platform code
dependencies overall, I can probably hand that branch off to Linus W. We
will see.
Thanks,
Sekhar
prev parent reply other threads:[~2013-12-15 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 17:52 [PATCH v7] gpio: davinci: use {readl|writel}_relaxed() instead of __raw_* Prabhakar Lad
2013-12-12 20:31 ` Linus Walleij
2013-12-13 4:04 ` Prabhakar Lad
2013-12-15 11:35 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AD9412.1010508@ti.com \
--to=nsekhar@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=taras.kondratiuk@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.