From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsI6m-0006tJ-UB for qemu-devel@nongnu.org; Sun, 15 Dec 2013 15:16:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsI6f-0003S0-Gr for qemu-devel@nongnu.org; Sun, 15 Dec 2013 15:16:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53567 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsI6f-0003Rr-AQ for qemu-devel@nongnu.org; Sun, 15 Dec 2013 15:16:05 -0500 Message-ID: <52AE0E00.7010606@suse.de> Date: Sun, 15 Dec 2013 21:16:00 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1385656023-11519-1-git-send-email-armbru@redhat.com> <1385656023-11519-3-git-send-email-armbru@redhat.com> In-Reply-To: <1385656023-11519-3-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 02/10] sysbus: Set cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, qemu-devel@nongnu.org, marcel.a@redhat.com Cc: borntraeger@de.ibm.com, aliguori@amazon.com, peter.maydell@linaro.org Am 28.11.2013 17:26, schrieb armbru@redhat.com: > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > index 146f50a..ed0477b 100644 > --- a/hw/core/sysbus.c > +++ b/hw/core/sysbus.c > @@ -257,6 +257,13 @@ static void sysbus_device_class_init(ObjectClass *= klass, void *data) > DeviceClass *k =3D DEVICE_CLASS(klass); > k->init =3D sysbus_device_init; > k->bus_type =3D TYPE_SYSTEM_BUS; > + /* > + * device_add plugs devices into suitable bus. For "real" buses, > + * that actually connects the device. For sysbus, the connections > + * need to be made separately, and device_add can't do that. The > + * device would be left unconncected, and could not possibly work. "unconnected" - fixed. Andreas > + */ > + k->cannot_instantiate_with_device_add_yet =3D true; > } > =20 > static const TypeInfo sysbus_device_type_info =3D { --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg