From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsIqA-0006xG-Em for qemu-devel@nongnu.org; Sun, 15 Dec 2013 16:03:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsIq3-0007MT-HW for qemu-devel@nongnu.org; Sun, 15 Dec 2013 16:03:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53922 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsIq3-0007MJ-Bg for qemu-devel@nongnu.org; Sun, 15 Dec 2013 16:02:59 -0500 Message-ID: <52AE18FE.9090908@suse.de> Date: Sun, 15 Dec 2013 22:02:54 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1385718225-26379-1-git-send-email-armbru@redhat.com> In-Reply-To: <1385718225-26379-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] Pointer properties and device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, marcel.a@redhat.com, chouteau@adacore.com, blauwirbel@gmail.com, kraxel@redhat.com, aliguori@amazon.com, edgar.iglesias@gmail.com Am 29.11.2013 10:43, schrieb armbru@redhat.com: > From: Markus Armbruster >=20 > Pointer properties can be set only by code, not by device_add. A > device with a pointer property can't work with device_add only unless > the property may remain null. cannot_instantiate_with_device_add_yet > needs to be set then. PATCH 1/2 sets it when needed and else > documents why not. PATCH 2/2 documents this for future users of > pointer properties. >=20 > This applies on top of my "[PATCH v4 00/10] Clean up and fix no_user" > series. >=20 > Markus Armbruster (2): > hw: cannot_instantiate_with_device_add_yet due to pointer props > qdev: Document that pointer properties kill device_add Queued both while still waiting for reply from PMM. I somewhat doubt that anyone will read the documentation you're adding in 2/2, but at least we can then point them to it. https://github.com/afaerber/qemu-cpu/commits/qom-next Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg