From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VsOHn-0001cw-SM
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:52:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VsOHf-00051N-HM
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:51:59 -0500
Received: from e28smtp08.in.ibm.com ([122.248.162.8]:53211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VsOHe-00051H-UC
	for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:51:51 -0500
Received: from /spool/local
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Mon, 16 Dec 2013 08:21:48 +0530
Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id 877A33940023
	for <qemu-devel@nongnu.org>; Mon, 16 Dec 2013 08:21:46 +0530 (IST)
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	rBG2pilp52559994
	for <qemu-devel@nongnu.org>; Mon, 16 Dec 2013 08:21:44 +0530
Received: from d28av01.in.ibm.com (localhost [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	rBG2pkR9005763
	for <qemu-devel@nongnu.org>; Mon, 16 Dec 2013 08:21:46 +0530
Message-ID: <52AE6AC5.2040200@linux.vnet.ibm.com>
Date: Mon, 16 Dec 2013 10:51:49 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1384307094-5836-3-git-send-email-xiawenc@linux.vnet.ibm.com>
	<52AB0C17.8020704@redhat.com>
In-Reply-To: <52AB0C17.8020704@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com

于 2013/12/13 21:31, Eric Blake 写道:
> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
>> Nested structure is not supported now, so following define is not valid:
>> { 'event': 'EVENT_C',
>>    'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
>
> But what IS valid?  You need to document this in docs/qapi-code-gen.txt
> at a bare minimum.
>
> This patch series is hard to review, and still has the RFC subject line.
>   At this point, I think it's worth rebasing and resending what you have;
> even if it needs more review, it will at least get it to a state that is
> easier to review.
>
   Sure, I will wait some time and respin.


>> +++ b/scripts/qapi-event.py
>> @@ -0,0 +1,355 @@
>> +#
>> +# QAPI event generator
>> +#
>> +# Copyright IBM, Corp. 2013
>> +#
>> +# Authors:
>> +#  Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> +#
>> +# This work is licensed under the terms of the GNU GPLv2.
>
> Can you please use GPLv2+ (that is, add the "or later" clause)?  We
> already have GPLv2-only code, but I don't want to increase the size of
> that unfortunate license choice.
>