From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsQNs-00060e-4n for qemu-devel@nongnu.org; Mon, 16 Dec 2013 00:06:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsQNj-0000U7-2P for qemu-devel@nongnu.org; Mon, 16 Dec 2013 00:06:24 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:47667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsQNi-0000Tp-SM for qemu-devel@nongnu.org; Mon, 16 Dec 2013 00:06:14 -0500 Received: by mail-pb0-f49.google.com with SMTP id jt11so4989549pbb.36 for ; Sun, 15 Dec 2013 21:06:14 -0800 (PST) Message-ID: <52AE8A38.4080902@ozlabs.ru> Date: Mon, 16 Dec 2013 16:06:00 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1386282785-466-1-git-send-email-mdroth@linux.vnet.ibm.com> <1386282785-466-15-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1386282785-466-15-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 14/14] spapr_pci: emit hotplug add/remove events during hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: agraf@suse.de, ncmike@ncultra.org, paulus@samba.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org On 12/06/2013 09:33 AM, Michael Roth wrote: > From: Tyrel Datwyler > > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. > > Userspace tools that don't implement this extension will need > to be run manually in response/advance of device_add/device_del, > respectively. > > Signed-off-by: Tyrel Datwyler > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 9b4f829..9821462 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -1129,14 +1129,18 @@ static void spapr_device_hotplug_remove(DeviceState *qdev, PCIDevice *dev) > static int spapr_device_hotplug(DeviceState *qdev, PCIDevice *dev, > PCIHotplugState state) > { sPAPRPHBState *phb = SPAPR_PCI_HOST_BRIDGE(qdev); > + int slot = PCI_SLOT(dev->devfn); > + > if (state == PCI_COLDPLUG_ENABLED) { > return 0; > } > > if (state == PCI_HOTPLUG_ENABLED) { > spapr_device_hotplug_add(qdev, dev); > + spapr_pci_hotplug_add_event(qdev, slot); spapr_pci_hotplug_add_event(phb->buid, slot); > } else { > spapr_device_hotplug_remove(qdev, dev); > + spapr_pci_hotplug_remove_event(qdev, slot); spapr_pci_hotplug_remove_event(phb->buid, slot); and fix spapr_pci_hotplug_(add|remove)_event to receive @buid instead of qdev/phb. Or we could even remove these helpers and call spapr_hotplug_req_event() directly. Would not that make things easier to read? > } > > return 0; > -- Alexey