From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign Date: Mon, 16 Dec 2013 11:04:42 +0000 Message-ID: <52AEDE4A.8050505@eu.citrix.com> References: <1386963461-6520-1-git-send-email-julien.grall@linaro.org> <1386963461-6520-2-git-send-email-julien.grall@linaro.org> <1386976760.20787.89.camel@dagon.hellion.org.uk> <52AB9FB4.9060100@linaro.org> <1387190714.20076.61.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VsVyi-0006Qs-Q8 for xen-devel@lists.xenproject.org; Mon, 16 Dec 2013 11:04:49 +0000 In-Reply-To: <1387190714.20076.61.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: Keir Fraser , patches@linaro.org, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 12/16/2013 10:45 AM, Ian Campbell wrote: > On Sat, 2013-12-14 at 00:00 +0000, Julien Grall wrote: >> On 12/13/2013 11:19 PM, Ian Campbell wrote: >>> On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote: >>>> From: Mukesh Rathor >>>> >>>> In this patch, a new type p2m_map_foreign is introduced for pages >>>> that toolstack on PVH dom0 maps from foreign domains that its creating >>>> or supporting during it's run time. >>>> >>>> Signed-off-by: Mukesh Rathor >>>> Cc: Jan Beulich >>>> Cc: Keir Fraser >>>> Cc: George Dunlap >>>> >>>> --- >>>> Changes in v4: >>>> - Use the patch #4 from dom0 pvh v6 series. We need it for ARM >>> Is this really the right patch? I'd have thought it would need to >>> include some generic/!x86 bits but: >> This patch introduce p2m_map_foreign type. I think it's safe to push it >> without the other patches. > Is it really that simple? I suppose there is nothing to create a foreign > mapping on x86 yet so this is harmless? > > I'm mostly concerned because the big remaining concern about this stuff > on x86 relates to the reference counting of foreign p2m entries. I'll > defer to the x86 chaps about whether that conversation is directly > related to or impacts this patch or not. Do you have the reference counting for the new p2m type sorted out sufficiently? -George