From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 06/11] ath9k_hw: remove ah->config.pcie_clock_req
Date: Mon, 16 Dec 2013 12:17:03 +0100 [thread overview]
Message-ID: <52AEE12F.5020008@openwrt.org> (raw)
In-Reply-To: <21166.30518.304613.545323@gargle.gargle.HOWL>
On 2013-12-16 04:44, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> - if (ah->config.pcie_clock_req)
>> - INIT_INI_ARRAY(&ah->iniPcieSerdes,
>> - ar9280PciePhy_clkreq_off_L1_9280);
>> - else
>> - INIT_INI_ARRAY(&ah->iniPcieSerdes,
>> - ar9280PciePhy_clkreq_always_on_L1_9280);
>> + INIT_INI_ARRAY(&ah->iniPcieSerdes,
>> + ar9280PciePhy_clkreq_always_on_L1_9280);
>>
>> if (AR_SREV_9287_11_OR_LATER(ah)) {
>> INIT_INI_ARRAY(&ah->iniModes, ar9287Modes_9287_1_1);
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>> index a403cfc..eeb0741 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.c
>> +++ b/drivers/net/wireless/ath/ath9k/hw.c
>> @@ -446,7 +446,6 @@ static void ath9k_hw_init_config(struct ath_hw *ah)
>> ah->config.additional_swba_backoff = 0;
>> ah->config.ack_6mb = 0x0;
>> ah->config.cwm_ignore_extcca = 0;
>> - ah->config.pcie_clock_req = 0;
>> ah->config.analog_shiftreg = 1;
>
> Please leave this in the driver, this has to be set for selected
> cards. I'll look at the Windows registry and add platform support.
Fine with me, let's leave this one out and merge the others (if there
aren't any other issues).
- Felix
next prev parent reply other threads:[~2013-12-16 11:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 17:03 [PATCH 01/11] ath9k_common: get rid of an unnecessary variable Felix Fietkau
2013-12-14 17:03 ` [PATCH 02/11] ath9k: add support for reporting per-chain signal strength Felix Fietkau
2013-12-14 17:03 ` [PATCH 03/11] ath9k_hw: use a software timer for btcoex no_stomp_timer Felix Fietkau
2013-12-14 17:03 ` [PATCH 04/11] ath9k_hw: clean up generic timer code Felix Fietkau
2013-12-14 17:03 ` [PATCH 05/11] ath9k_hw: remove defunct ad-hoc mode ATIM window handling code Felix Fietkau
2013-12-14 17:03 ` [PATCH 06/11] ath9k_hw: remove ah->config.pcie_clock_req Felix Fietkau
2013-12-16 3:44 ` Sujith Manoharan
2013-12-16 11:17 ` Felix Fietkau [this message]
2013-12-16 13:09 ` Sujith Manoharan
2013-12-16 13:51 ` Felix Fietkau
2013-12-16 14:06 ` Johannes Berg
2013-12-14 17:03 ` [PATCH 07/11] ath9k_hw: simplify spur channel handling Felix Fietkau
2013-12-14 17:03 ` [PATCH 08/11] ath9k_hw: remove additional_swba_backoff Felix Fietkau
2013-12-14 17:03 ` [PATCH 09/11] ath9k_hw: remove spur related unused defines Felix Fietkau
2013-12-14 17:03 ` [PATCH 10/11] ath9k_hw: clean up station beacon timer API Felix Fietkau
2013-12-14 17:03 ` [PATCH 11/11] ath9k: properly preserve TSF across reset Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AEE12F.5020008@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.