All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap()
Date: Mon, 16 Dec 2013 13:09:05 +0100	[thread overview]
Message-ID: <52AEED61.6030906@metafoo.de> (raw)
In-Reply-To: <1387195644-28513-1-git-send-email-lars@metafoo.de>

oops, the subject should clearly be:

ASoC: axi-i2s: Use devm_ioremap_resource() instead \
 of devm_request_and_ioremap()

On 12/16/2013 01:07 PM, Lars-Peter Clausen wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> devm_request_and_ioremap() has been deprecated in favour of
> devm_ioremap_resource(). Fixes the following coccinelle warning:
> 
> 	sound/soc/adi/axi-i2s.c:195:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 195
> 
> Generated by: coccinelle/api/devm_ioremap_resource.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  sound/soc/adi/axi-i2s.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c
> index 0822c77..7f91a86 100644
> --- a/sound/soc/adi/axi-i2s.c
> +++ b/sound/soc/adi/axi-i2s.c
> @@ -192,9 +192,9 @@ static int axi_i2s_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, i2s);
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base)
> -		return -EBUSY;
> +	base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base))
> +		return PTR_ERR(base);
>  
>  	i2s->regmap = devm_regmap_init_mmio(&pdev->dev, base,
>  		&axi_i2s_regmap_config);
> 

  parent reply	other threads:[~2013-12-16 12:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 12:07 [PATCH 1/2] ASoC: ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap() Lars-Peter Clausen
2013-12-16 12:07 ` [PATCH 2/2] " Lars-Peter Clausen
2013-12-16 12:09 ` Lars-Peter Clausen [this message]
2013-12-16 20:46 ` [PATCH 1/2] ASoC: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AEED61.6030906@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.