diff for duplicates of <52AF130A.1090503@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 2f174cd..6e4ab06 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -111,10 +111,10 @@ On 2013/12/16 22:32, Neil Horman wrote: > It really seems like there should be a way to roll up what you want into the > try_then_request_module macro. What about: > -> ret = try_then_request_module((register_jprobe(...) = 0), "sctp"); +> ret = try_then_request_module((register_jprobe(...) == 0), "sctp"); > The first problem maybe exist. because the last value is x. So if use this -it always return (register_jprobe(...) = 0) while the value is only 1 or 0. +it always return (register_jprobe(...) == 0) while the value is only 1 or 0. > That seems like it should work. It will mask the actual return value of > register_jprobe though I think, which kind of sucks. Its almost like we need @@ -122,7 +122,7 @@ it always return (register_jprobe(...) = 0) while the value is only 1 or 0. > macro can use it to compare, something like: > > #define try_then_request_module_cond(x, result, mod...) \ -> ((x) = (result) ?: __request_module(true, mod), (x))) +> ((x) == (result) ?: __request_module(true, mod), (x))) > > that would let you set an expected comparison value for your macro, but get the > result of the method if it still fails after the module is loaded, or if it diff --git a/a/content_digest b/N1/content_digest index 8d5f5a9..6839b88 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\020131216143223.GB19809@hmsreliant.think-freely.org\0" "From\0Wang Weidong <weidong1991.wang@gmail.com>\0" "Subject\0Re: [PATCH v2] sctp: loading sctp when load sctp_probe\0" - "Date\0Mon, 16 Dec 2013 14:49:46 +0000\0" + "Date\0Mon, 16 Dec 2013 22:49:46 +0800\0" "To\0Neil Horman <nhorman@tuxdriver.com>\0" "Cc\0Vlad Yasevich <vyasevich@gmail.com>" David Miller <davem@davemloft.net> @@ -127,10 +127,10 @@ "> It really seems like there should be a way to roll up what you want into the\n" "> try_then_request_module macro. What about:\n" ">\n" - "> ret = try_then_request_module((register_jprobe(...) = 0), \"sctp\");\n" + "> ret = try_then_request_module((register_jprobe(...) == 0), \"sctp\");\n" ">\n" "The first problem maybe exist. because the last value is x. So if use this\n" - "it always return (register_jprobe(...) = 0) while the value is only 1 or 0.\n" + "it always return (register_jprobe(...) == 0) while the value is only 1 or 0.\n" "\n" "> That seems like it should work. It will mask the actual return value of\n" "> register_jprobe though I think, which kind of sucks. Its almost like we need\n" @@ -138,7 +138,7 @@ "> macro can use it to compare, something like:\n" ">\n" "> #define try_then_request_module_cond(x, result, mod...) \\\n" - "> \t((x) = (result) ?: __request_module(true, mod), (x)))\n" + "> \t((x) == (result) ?: __request_module(true, mod), (x)))\n" ">\n" "> that would let you set an expected comparison value for your macro, but get the\n" "> result of the method if it still fails after the module is loaded, or if it\n" @@ -159,4 +159,4 @@ "Regards.\n" Wang -866a764f8cd14e61fa5e29a94189de82f6933febfff856b34f70a823c6f383f9 +4b01241fd57c3a4bc19ac2d1706f7994a682a2621798fbb9d40e0d9a2ff17d7a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.