Re: [PATCH v2] mac80211: add helper functions for tracking P2P NoA state

[Felix Fietkau <nbd@openwrt.org>]

On 2013-12-16 16:09, Johannes Berg wrote:
> On Mon, 2013-12-09 at 22:59 +0100, Felix Fietkau wrote:
> 
>> +static u32
>> +ieee80211_get_noa_absent_time(struct ieee80211_noa_data *data, u32 tsf)
>> +{
>> +	s32 offset = 0;
>> +	int tries = 0;
>> +
>> +	ieee80211_extend_absent_time(data, tsf, &offset);
>> +	do {
>> +		if (!ieee80211_extend_absent_time(data, tsf, &offset))
>> +			break;
>> +
>> +		tries++;
>> +	} while (tries < 5);
> 
> What's "tries < 5"?
Arbitrary value. It tries to merge up to 5 intervals of each NoA
descriptor. I can't let it try forever because that can easily make it
run into an infinite loop if the combination of the NoA descriptors
doesn't leave any presence time inbetween.

- Felix