From: "Jan Beulich" <JBeulich@suse.com>
To: <tony.luck@intel.com>
Cc: "Matt Fleming" <matt.fleming@intel.com>, <mingo@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] don't select EFI from certain special ACPI drivers
Date: Mon, 16 Dec 2013 14:39:40 +0000 [thread overview]
Message-ID: <52AF1EBC020000780010DBF9@nat28.tlf.novell.com> (raw)
Commit 7ea6c6c1 ("Move cper.c from drivers/acpi/apei to
drivers/firmware/efi") results in CONFIG_EFI being enabled even when
the user doesn't want this. Since ACPI APEI used to build fine without
UEFI (and as far as I know also has no functional depency on it), at
least in that case using a reverse dependency is wrong (and a straight
one isn't needed).
Whether the same is true for ACPI_EXTLOG I don't know - if there is a
functional dependency, it should depend on EFI rather than selecting
it. It certainly has (currently) no build dependency.
Adjust Kconfig and build logic so that the bad dependency gets avoided.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
---
drivers/acpi/Kconfig | 1 -
drivers/acpi/apei/Kconfig | 1 -
drivers/firmware/Makefile | 1 +
drivers/firmware/efi/Kconfig | 6 +++---
drivers/firmware/efi/Makefile | 2 +-
5 files changed, 5 insertions(+), 6 deletions(-)
--- 3.13-rc4/drivers/acpi/Kconfig
+++ 3.13-rc4-ACPI-CPER-no-EFI/drivers/acpi/Kconfig
@@ -348,7 +348,6 @@ source "drivers/acpi/apei/Kconfig"
config ACPI_EXTLOG
tristate "Extended Error Log support"
depends on X86_MCE && X86_LOCAL_APIC
- select EFI
select UEFI_CPER
default n
help
--- 3.13-rc4/drivers/acpi/apei/Kconfig
+++ 3.13-rc4-ACPI-CPER-no-EFI/drivers/acpi/apei/Kconfig
@@ -2,7 +2,6 @@ config ACPI_APEI
bool "ACPI Platform Error Interface (APEI)"
select MISC_FILESYSTEMS
select PSTORE
- select EFI
select UEFI_CPER
depends on X86
help
--- 3.13-rc4/drivers/firmware/Makefile
+++ 3.13-rc4-ACPI-CPER-no-EFI/drivers/firmware/Makefile
@@ -14,3 +14,4 @@ obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.
obj-$(CONFIG_GOOGLE_FIRMWARE) += google/
obj-$(CONFIG_EFI) += efi/
+obj-$(CONFIG_UEFI_CPER) += efi/
--- 3.13-rc4/drivers/firmware/efi/Kconfig
+++ 3.13-rc4-ACPI-CPER-no-EFI/drivers/firmware/efi/Kconfig
@@ -36,7 +36,7 @@ config EFI_VARS_PSTORE_DEFAULT_DISABLE
backend for pstore by default. This setting can be overridden
using the efivars module's pstore_disable parameter.
-config UEFI_CPER
- def_bool n
-
endmenu
+
+config UEFI_CPER
+ bool
--- 3.13-rc4/drivers/firmware/efi/Makefile
+++ 3.13-rc4-ACPI-CPER-no-EFI/drivers/firmware/efi/Makefile
@@ -1,7 +1,7 @@
#
# Makefile for linux kernel
#
-obj-y += efi.o vars.o
+obj-$(CONFIG_EFI) += efi.o vars.o
obj-$(CONFIG_EFI_VARS) += efivars.o
obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
obj-$(CONFIG_UEFI_CPER) += cper.o
next reply other threads:[~2013-12-16 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 14:39 Jan Beulich [this message]
2013-12-16 23:04 ` [PATCH] don't select EFI from certain special ACPI drivers Luck, Tony
2013-12-17 8:05 ` Jan Beulich
2013-12-17 22:34 ` Luck, Tony
2013-12-18 8:04 ` Jan Beulich
2013-12-18 19:13 ` Tony Luck
2013-12-19 16:56 ` Ingo Molnar
2013-12-19 20:36 ` [tip:x86/urgent] x86/efi: Don' t " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF1EBC020000780010DBF9@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.