From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Vadim Rozenfeld" <vrozenfe@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling'
Date: Mon, 16 Dec 2013 09:51:08 -0700 [thread overview]
Message-ID: <52AF2F7C.3010506@redhat.com> (raw)
In-Reply-To: <1373927181-24247-7-git-send-email-imammedo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On 07/15/2013 04:25 PM, Igor Mammedov wrote:
> features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on'
> when passed from command line, so it's not neccessary to handle each of them
s/neccessary/necessary/
> separetly. Collapse them to one catch-all branch which will treat
s/separetly/separately/
> any feature in format 'foo' as boolean set to 'on'.
>
> PS:
> Any unknown feature will be rejected by CPU property setter so there is no
> need to check for unknown feature in cpu_x86_parse_featurestr(), therefore
> it's replaced by above mentioned catch-all handler.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-12-16 16:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 22:25 [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 01/20] target-i386: Move hyperv_* static globals to X86CPU Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property Igor Mammedov
2013-11-27 17:55 ` Andreas Färber
2013-11-27 18:05 ` Paolo Bonzini
2013-11-27 18:21 ` Igor Mammedov
2013-11-27 21:21 ` Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 03/20] target-i386: convert 'hv_relaxed' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 04/20] target-i386: convert 'hv_vapic' " Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 05/20] target-i386: convert 'check' and 'enforce' to static properties Igor Mammedov
2013-07-15 22:25 ` [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling' Igor Mammedov
2013-12-16 16:51 ` Eric Blake [this message]
2013-12-19 16:32 ` Andreas Färber
2013-07-15 22:26 ` [Qemu-devel] [PATCH 07/20] target-i386: cleanup 'foo=val' feature handling Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 08/20] target-i386: cpu: convert 'level' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 09/20] target-i386: cpu: convert 'xlevel' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 10/20] target-i386: cpu: convert 'family' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 11/20] target-i386: cpu: convert 'model' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 12/20] target-i386: cpu: convert 'stepping' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 13/20] target-i386: cpu: convert 'vendor' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 14/20] target-i386: cpu: convert 'model-id' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/20] target-i386: cpu: convert 'tsc-frequency' " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 15/21] target-i386: cpu: substitute '_' with '-' for +-foo feature bits as well Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/21] target-i386: cpu: convert 'tsc-frequency' to static property Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 16/20] target-i386: set [+-]feature using static properties Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/20] qdev: introduce qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 17/21] target-i386: set [+-]feature using static properties Igor Mammedov
2013-10-15 16:22 ` Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/21] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit() Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 18/20] target-i386: use static properties in check_features_against_host() to print CPUID feature names Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/21] " Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 19/20] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/20] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 20/21] target-i386: use static properties to list CPUID features Igor Mammedov
2013-07-15 22:26 ` [Qemu-devel] [PATCH 21/21] target-i386: remove unused *_feature_name arrays Igor Mammedov
2013-10-14 12:09 ` [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties Igor Mammedov
2013-10-14 18:05 ` Andreas Färber
2013-10-15 12:27 ` Vadim Rozenfeld
2013-11-25 16:56 ` Igor Mammedov
2013-12-15 21:48 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF2F7C.3010506@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.