Re: [PATCH -next] ASoC: tegra20-ac97: fix error return code in tegra20_ac97_platform_probe()

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 12/13/2013 10:15 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> 
> Fix to return -ENODEV instead of 0 when no GPIO supplied in
> tegra20_ac97_platform_probe().

> diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c

> @@ -358,6 +358,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
>  		}
>  	} else {
>  		dev_err(&pdev->dev, "no codec-reset GPIO supplied\n");
> +		ret = -ENODEV;

This would be better as:

		ret = ac97->reset_gpio;

Since that will propagate the exact error code (and incidentally,
deferred probe will work correctly then).

>  	if (!gpio_is_valid(ac97->sync_gpio)) {
>  		dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
> +		ret = -ENODEV;

Similarly here,

		ret = ac97->sync_gpio;