From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign Date: Mon, 16 Dec 2013 17:15:53 +0000 Message-ID: <52AF3549.8000400@linaro.org> References: <1386963461-6520-1-git-send-email-julien.grall@linaro.org> <1386963461-6520-2-git-send-email-julien.grall@linaro.org> <1386976760.20787.89.camel@dagon.hellion.org.uk> <52AB9FB4.9060100@linaro.org> <1387190714.20076.61.camel@kazak.uk.xensource.com> <20131216105913.GA35881@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vsblt-0000ii-CT for xen-devel@lists.xenproject.org; Mon, 16 Dec 2013 17:15:57 +0000 Received: by mail-wg0-f48.google.com with SMTP id z12so4837679wgg.15 for ; Mon, 16 Dec 2013 09:15:55 -0800 (PST) In-Reply-To: <20131216105913.GA35881@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan , Ian Campbell Cc: Keir Fraser , patches@linaro.org, George Dunlap , stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 12/16/2013 10:59 AM, Tim Deegan wrote: > At 10:45 +0000 on 16 Dec (1387187114), Ian Campbell wrote: >> On Sat, 2013-12-14 at 00:00 +0000, Julien Grall wrote: >>> >>> On 12/13/2013 11:19 PM, Ian Campbell wrote: >>>> On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote: >>>>> From: Mukesh Rathor >>>>> >>>>> In this patch, a new type p2m_map_foreign is introduced for pages >>>>> that toolstack on PVH dom0 maps from foreign domains that its creating >>>>> or supporting during it's run time. >>>>> >>>>> Signed-off-by: Mukesh Rathor >>>>> Cc: Jan Beulich >>>>> Cc: Keir Fraser >>>>> Cc: George Dunlap >>>>> >>>>> --- >>>>> Changes in v4: >>>>> - Use the patch #4 from dom0 pvh v6 series. We need it for ARM >>>> >>>> Is this really the right patch? I'd have thought it would need to >>>> include some generic/!x86 bits but: >>> >>> This patch introduce p2m_map_foreign type. I think it's safe to push it >>> without the other patches. >> >> Is it really that simple? I suppose there is nothing to create a foreign >> mapping on x86 yet so this is harmless? > > Presumably you're about to add some common code that creates foreign > mappings -- otherwise there would be no need to take the x86 patch. > In that case, it's not really safe to take only part of the x86 > implementation. It'd be better to stub out any x86 interfaces with > explicit errors, to be removed when x86 supports this properly. This patch is no longer necessary. I have reworked my patch #8 to remove modification in common code. -- Julien Grall