From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2] use grub_util_exec_redirect_all to silence "moprobe efivars"
Date: Mon, 16 Dec 2013 19:29:51 +0100 [thread overview]
Message-ID: <52AF469F.7050009@gmail.com> (raw)
In-Reply-To: <1387218052-22765-3-git-send-email-arvidjaar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
Go ahead for both patches.
Could you also add a grub_util_info detailing which directories were
tried and if they were found or not? To provide info about why GRUB
assumed this or that platform.
On 16.12.2013 19:20, Andrey Borzenkov wrote:
> ---
> grub-core/osdep/linux/platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/grub-core/osdep/linux/platform.c b/grub-core/osdep/linux/platform.c
> index ec67aad..86561f7 100644
> --- a/grub-core/osdep/linux/platform.c
> +++ b/grub-core/osdep/linux/platform.c
> @@ -69,8 +69,8 @@ grub_install_get_default_x86_platform (void)
> anyway later. So it should be safe to
> try to load it here.
> */
> - grub_util_exec ((const char * []){ "modprobe", "-q",
> - "efivars", NULL });
> + grub_util_exec_redirect_all ((const char * []){ "modprobe", "efivars", NULL },
> + NULL, NULL, "/dev/null");
> if (is_not_empty_directory ("/sys/firmware/efi"))
> {
> if (is_64_kernel ())
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-12-16 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 19:24 [grub-devel] fatal error message on grub-install for i386-pc (x86-64) with latest repo Javier Vasquez
2013-12-15 21:49 ` Javier Vasquez
2013-12-16 2:22 ` Andrey Borzenkov
2013-12-16 18:20 ` [PATCH 0/2] allow redirect of stderr in grub_util_exec* Andrey Borzenkov
2013-12-16 18:20 ` [PATCH 1/2] consolidate grub_util_exec code Andrey Borzenkov
2013-12-16 18:20 ` [PATCH 2/2] use grub_util_exec_redirect_all to silence "moprobe efivars" Andrey Borzenkov
2013-12-16 18:29 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF469F.7050009@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.