From: Anand Jain <Anand.Jain@oracle.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs_progs: handle error in the btrfs_prepare_device
Date: Tue, 17 Dec 2013 10:40:16 +0800 [thread overview]
Message-ID: <52AFB990.8030707@oracle.com> (raw)
In-Reply-To: <93924585-F0F1-4BA8-880D-E9D27EF2C2CD@gmail.com>
Thanks Wang.
> s/btrfs_progs/btrfs-progs?
yeah. updated my script.
>> +
>> +zero_dev_error:
>> + if (ret) {
>> + ret < 0 ?
>> + fprintf(stderr, "ERROR: failed to zero device start '%s' - %s\n",
>> + file, strerror(-ret)) :
>> + fprintf(stderr, "ERROR: failed to zero device start '%s' - %d\n",
>> + file, ret);
>
> Why we output message twice here….
Not really. there is "ret < 0 ?"
-Anand
prev parent reply other threads:[~2013-12-17 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 12:33 [PATCH 1/3] btrfs_progs: don't replicate the stripe_len defines Anand Jain
2013-12-16 12:33 ` [PATCH 2/3] btrfs_progs: use stripe_len define here Anand Jain
2013-12-16 13:59 ` David Sterba
2013-12-16 12:33 ` [PATCH 3/3] btrfs_progs: handle error in the btrfs_prepare_device Anand Jain
2013-12-16 12:38 ` Wang Shilong
2013-12-17 2:40 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AFB990.8030707@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.