Re: [PATCH v2 3/3] btrfs-progs: handle error in the btrfs_prepare_device

[Anand Jain <Anand.Jain@oracle.com>]

>> +	ret = btrfs_prepare_device(fddstdev, dstdev, 1, &dstdev_block_count, 0,
>> +				 &mixed, 0);
>>   	close(fddstdev);
>> +	if (ret)
>> +		goto leave_with_error;


>>   	fddstdev = -1;

  yeah moved this 3 lines up. thanks.

> You change the code to call close(fddstdev) twice.
>
> [...]
>> +zero_dev_error:
>> +	if (ret) {
>> +		ret < 0 ?
>> +		fprintf(stderr, "ERROR: failed to zero device start '%s' - %s\n",
>> +			file, strerror(-ret)) :
>> +		fprintf(stderr, "ERROR: failed to zero device start '%s' - %d\n",
>> +			file, ret);
>
> This is not funny.

  hmm. I am not sure what you mean ?

Thanks, Anand