From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <52B02598.5060004@ti.com> Date: Tue, 17 Dec 2013 12:21:12 +0200 From: "ivan.khoronzhuk" MIME-Version: 1.0 To: Brian Norris Subject: Re: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration References: <1386264358-9738-1-git-send-email-ivan.khoronzhuk@ti.com> <1386264358-9738-2-git-send-email-ivan.khoronzhuk@ti.com> <20131217092449.GL12034@norris-Latitude-E6410> In-Reply-To: <20131217092449.GL12034@norris-Latitude-E6410> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Mark Rutland , devicetree@vger.kernel.org, grygorii.strashko@ti.com, Russell King , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Rob Herring , linux-kernel@vger.kernel.org, Santosh Shilimkar , Rob Landley , linux-mtd@lists.infradead.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/17/2013 11:24 AM, Brian Norris wrote: > On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev) >> } >> >> static struct platform_driver nand_davinci_driver = { >> + .probe = nand_davinci_probe, >> .remove = __exit_p(nand_davinci_remove), > > I believe you need to drop the __exit_p() here. And now that you're > using module_platform_driver(), you need to drop the __init and __exit > from the probe() and remove() routines, to avoid section mismatch > warnings. > >> .driver = { >> .name = "davinci_nand", > > So on second thought, please resubmit the series with the requested > changes. > > Thanks, > Brian > Thanks, Brian. Do you want me to drop it in stand alone patch or in this one? -- Regards, Ivan Khoronzhuk From mboxrd@z Thu Jan 1 00:00:00 1970 From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk) Date: Tue, 17 Dec 2013 12:21:12 +0200 Subject: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration In-Reply-To: <20131217092449.GL12034@norris-Latitude-E6410> References: <1386264358-9738-1-git-send-email-ivan.khoronzhuk@ti.com> <1386264358-9738-2-git-send-email-ivan.khoronzhuk@ti.com> <20131217092449.GL12034@norris-Latitude-E6410> Message-ID: <52B02598.5060004@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/17/2013 11:24 AM, Brian Norris wrote: > On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev) >> } >> >> static struct platform_driver nand_davinci_driver = { >> + .probe = nand_davinci_probe, >> .remove = __exit_p(nand_davinci_remove), > > I believe you need to drop the __exit_p() here. And now that you're > using module_platform_driver(), you need to drop the __init and __exit > from the probe() and remove() routines, to avoid section mismatch > warnings. > >> .driver = { >> .name = "davinci_nand", > > So on second thought, please resubmit the series with the requested > changes. > > Thanks, > Brian > Thanks, Brian. Do you want me to drop it in stand alone patch or in this one? -- Regards, Ivan Khoronzhuk From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ivan.khoronzhuk" Subject: Re: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration Date: Tue, 17 Dec 2013 12:21:12 +0200 Message-ID: <52B02598.5060004@ti.com> References: <1386264358-9738-1-git-send-email-ivan.khoronzhuk@ti.com> <1386264358-9738-2-git-send-email-ivan.khoronzhuk@ti.com> <20131217092449.GL12034@norris-Latitude-E6410> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131217092449.GL12034@norris-Latitude-E6410> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Brian Norris Cc: Mark Rutland , devicetree@vger.kernel.org, grygorii.strashko@ti.com, Russell King , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Rob Herring , linux-kernel@vger.kernel.org, Santosh Shilimkar , Rob Landley , linux-mtd@lists.infradead.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 12/17/2013 11:24 AM, Brian Norris wrote: > On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev) >> } >> >> static struct platform_driver nand_davinci_driver = { >> + .probe = nand_davinci_probe, >> .remove = __exit_p(nand_davinci_remove), > > I believe you need to drop the __exit_p() here. And now that you're > using module_platform_driver(), you need to drop the __init and __exit > from the probe() and remove() routines, to avoid section mismatch > warnings. > >> .driver = { >> .name = "davinci_nand", > > So on second thought, please resubmit the series with the requested > changes. > > Thanks, > Brian > Thanks, Brian. Do you want me to drop it in stand alone patch or in this one? -- Regards, Ivan Khoronzhuk ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962Ab3LQKXS (ORCPT ); Tue, 17 Dec 2013 05:23:18 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:36686 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929Ab3LQKXQ (ORCPT ); Tue, 17 Dec 2013 05:23:16 -0500 Message-ID: <52B02598.5060004@ti.com> Date: Tue, 17 Dec 2013 12:21:12 +0200 From: "ivan.khoronzhuk" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Brian Norris CC: Santosh Shilimkar , Rob Landley , Russell King , , Pawel Moll , Mark Rutland , Rob Herring , Stephen Warren , Kumar Gala , Ian Campbell , , , , , Subject: Re: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration References: <1386264358-9738-1-git-send-email-ivan.khoronzhuk@ti.com> <1386264358-9738-2-git-send-email-ivan.khoronzhuk@ti.com> <20131217092449.GL12034@norris-Latitude-E6410> In-Reply-To: <20131217092449.GL12034@norris-Latitude-E6410> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.145.122] X-EXCLAIMER-MD-CONFIG: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/2013 11:24 AM, Brian Norris wrote: > On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev) >> } >> >> static struct platform_driver nand_davinci_driver = { >> + .probe = nand_davinci_probe, >> .remove = __exit_p(nand_davinci_remove), > > I believe you need to drop the __exit_p() here. And now that you're > using module_platform_driver(), you need to drop the __init and __exit > from the probe() and remove() routines, to avoid section mismatch > warnings. > >> .driver = { >> .name = "davinci_nand", > > So on second thought, please resubmit the series with the requested > changes. > > Thanks, > Brian > Thanks, Brian. Do you want me to drop it in stand alone patch or in this one? -- Regards, Ivan Khoronzhuk