From: Amir Vadai <amirv@mellanox.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: mlx4_en: Using blue flame support
Date: Tue, 17 Dec 2013 12:55:08 +0000 [thread overview]
Message-ID: <52B049AC.50008@mellanox.com> (raw)
In-Reply-To: <20131217115730.GA10787@elgon.mountain>
On 17/12/2013 13:57, Dan Carpenter wrote:
> 838 if (ring->bf_enabled && desc_size <= MAX_BF && !bounce && !vlan_tx_tag_present(skb)) {
> 839 *(__be32 *) (&tx_desc->ctrl.vlan_tag) |= cpu_to_be32(ring->doorbell_qpn);
>
> And then sometimes we overwrite them here. It's not clear if this is
> deliberate or accidental. Maybe add a comment?
Yes, this is deliberate.
I will send a patch to make it clearer.
Amir
prev parent reply other threads:[~2013-12-17 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 11:57 mlx4_en: Using blue flame support Dan Carpenter
2013-12-17 12:55 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B049AC.50008@mellanox.com \
--to=amirv@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.