From: Michal Schmidt <mschmidt@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv6: sit: update mtu check to take care of gso packets
Date: Tue, 17 Dec 2013 15:22:37 +0100 [thread overview]
Message-ID: <52B05E2D.6060001@redhat.com> (raw)
In-Reply-To: <1387204283.19078.240.camel@edumazet-glaptop2.roam.corp.google.com>
On 12/16/2013 03:31 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> While testing my changes for TSO support in SIT devices,
> I was using sit0 tunnel which appears to include nopmtudisc flag.
>
> But using :
>
> ip tun add sittun mode sit remote $REMOTE_IPV4 local $LOCAL_IPV4 \
> dev $IFACE
>
> We get a tunnel which rejects too long packets because of the mtu check
> which is not yet GSO aware.
>
> erd:~# ip tunnel
> sittun: ipv6/ip remote 10.246.17.84 local 10.246.17.83 ttl inherit 6rd-prefix 2002::/16
> sit0: ipv6/ip remote any local any ttl 64 nopmtudisc 6rd-prefix 2002::/16
>
> This patch is based on an excellent report from
> Michal Shmidt.
>
> In the future, we probably want to extend the MTU check to do the
> right thing for GSO packets...
>
> Fixes: ("61c1db7fae21 ipv6: sit: add GSO/TSO support")
> Reported-by: Michal Schmidt <mschmidt@redhat.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Michal Schmidt <mschmidt@redhat.com>
It works fine now. Thanks.
Michal
next prev parent reply other threads:[~2013-12-17 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 16:13 sit tunnel slow since added GSO/TSO support Michal Schmidt
2013-12-13 16:28 ` Eric Dumazet
2013-12-13 22:54 ` Eric Dumazet
2013-12-14 21:25 ` Michal Schmidt
2013-12-15 1:23 ` Eric Dumazet
2013-12-16 14:31 ` [PATCH] ipv6: sit: update mtu check to take care of gso packets Eric Dumazet
2013-12-17 14:22 ` Michal Schmidt [this message]
2013-12-17 14:48 ` Eric Dumazet
2013-12-17 20:19 ` Hannes Frederic Sowa
2013-12-17 21:34 ` Eric Dumazet
2013-12-18 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B05E2D.6060001@redhat.com \
--to=mschmidt@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.