All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] manual: update for multiple global patch dirs
Date: Tue, 17 Dec 2013 15:31:57 +0100	[thread overview]
Message-ID: <52B0605D.5000905@mind.be> (raw)
In-Reply-To: <CAAXf6LWmNBvqDv5Nw7z+5VaV0Cx3UuWt6Ybo9LyfwLVuGAOLPg@mail.gmail.com>

On 17/12/13 14:30, Thomas De Schampheleire wrote:
> On Tue, Dec 17, 2013 at 2:19 PM, Arnout Vandecappelle<arnout@mind.be>  wrote:
> [..]
>>>> >>>
>>>> >>>
>>>> >>>-For a specific version <packageversion> of a specific package
>>>> >>><packagename>,
>>>> >>>-patches are applied as follows.
>>>> >>>+For a specific version +<packageversion>+ of a specific package
>>>> >>>++<packagename>+, patches are applied from +BR2_GLOBAL_PATCH_DIR+ as
>>>> >>>+follows:
>>>> >>>
>>>> >>>-First, the default Buildroot patch set for the package is applied.
>>>> >>>+. For every directory - +<global-patch-dir>+ - that exists in
>>>> >>>+  +BR2_GLOBAL_PATCH_DIR+, a +<package-patch-dir>+ will be determined as
>>>> >>>+  follows:
>>>> >>>++
>>>> >>>+* If the directory
>>>> >>>+  +<global-patch-dir>/<packagename>/<packageversion>/+ exists.
>>>> >>>++
>>>> >>>+* Otherwise, if the directory +<global-patch-dir>/<packagename>+ exists.
>>> >>
>>> >>
>>> >>I find this wording strange:
>>> >>'.... will be determined as follows: if the directory A exists.
>>> >>Otherwise, if the directory B exists.'
>>> >>
>>> >>What about:
>>> >>'.... will be determined as follows: A, if it exists. Otherwise, B, if
>>> >>it exists.'
>> >
>> >
>> >  Actually for me, Ryan's formulation sounds more natural: if ... else if ...
>> >else ....
>
> The order of if/else are both fine for me, but I was more referring to
> something else. The intro sentence says: "The order will be determined
> as follows". When I read this, I expect to get a summary of items (the
> 'order'). However, what follows is a list of conditionals ("if A")
> without 'then' statement.
>
> It's a bit like this to me:
> "On lazy days, I do only two things: if I am hungry, and if I am sleepy."
> while I expect more something like:
> "On lazy days, I do only two things: if I am hungry, I eat, and if I
> am sleepy, I sleep."

  Oh, yes, you're right, I didn't read it carefully. The 'then' is 
missing, and it can indeed be avoided by putting the 'if' behind it.

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-12-17 14:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  9:00 [Buildroot] [PATCH v4 1/2] Support for multiple BR2_GLOBAL_PATCH_DIR Ryan Barnett
2013-12-17  9:00 ` [Buildroot] [PATCH v4 2/2] manual: update for multiple global patch dirs Ryan Barnett
2013-12-17 12:58   ` Thomas De Schampheleire
2013-12-17 13:19     ` Arnout Vandecappelle
2013-12-17 13:30       ` Thomas De Schampheleire
2013-12-17 14:31         ` Arnout Vandecappelle [this message]
2013-12-17 14:24       ` Ryan Barnett
2013-12-17 15:02         ` Thomas Petazzoni
2013-12-17 15:43           ` Arnout Vandecappelle
2013-12-17 16:07         ` Thomas De Schampheleire
2013-12-17 16:09           ` Thomas De Schampheleire
2013-12-17 16:30           ` Ryan Barnett
2013-12-17 12:46 ` [Buildroot] [PATCH v4 1/2] Support for multiple BR2_GLOBAL_PATCH_DIR Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B0605D.5000905@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.