From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: haojian.zhuang@gmail.com, Qiao Zhou <zhouqiao@marvell.com>,
alsa-devel@alsa-project.org, zhangfei.gao@gmail.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: mmp-pcm: config pcm slave via generic dmaengine
Date: Tue, 17 Dec 2013 15:42:52 +0100 [thread overview]
Message-ID: <52B062EC.2050605@metafoo.de> (raw)
In-Reply-To: <20131217124954.GY3185@sirena.org.uk>
On 12/17/2013 01:49 PM, Mark Brown wrote:
> On Tue, Dec 17, 2013 at 04:22:24PM +0800, Qiao Zhou wrote:
>> use snd_dmaengine_pcm_prepare_slave_config to set slave config,
>> and remove the max_burst_size = 4 hard code.
>>
>> select SND_SOC_GENERIC_DMAENGINE_PCM for mmp-pcm.
>
> Applied, thanks. Can you also convert to use snd_dmaengine_pcm_register()
> and remove this file completely?
>
The problem here is that the driver uses sram for its audio memory and the
platform has a custom function for looking up the sram pool. What we really
need is a generic version of that which we can use in memalloc.c in the core.
- Lars
next prev parent reply other threads:[~2013-12-17 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:22 [PATCH] ASoC: mmp-pcm: config pcm slave via generic dmaengine Qiao Zhou
2013-12-17 12:49 ` Mark Brown
2013-12-17 14:42 ` Lars-Peter Clausen [this message]
2013-12-17 21:38 ` Mark Brown
2013-12-18 5:55 ` Qiao Zhou
2013-12-18 9:16 ` Lars-Peter Clausen
2013-12-18 10:20 ` Takashi Iwai
2013-12-18 11:03 ` Mark Brown
2013-12-18 10:14 ` Lars-Peter Clausen
2013-12-18 11:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B062EC.2050605@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=zhangfei.gao@gmail.com \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.