From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen: Pass the location of the ACPI RSDP to
 DOM0.
Date: Tue, 17 Dec 2013 19:27:47 +0000
Message-ID: <52B0A5B3.6090903@citrix.com>
References: <CAO5Rg13ezpV=99pPA2jJ8T7TsDsxAD6HuATOcZgXd0mGKehwsQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAO5Rg13ezpV=99pPA2jJ8T7TsDsxAD6HuATOcZgXd0mGKehwsQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Philip Wernersbach <philip.wernersbach@gmail.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 17/12/13 19:09, Philip Wernersbach wrote:
> I can't post patches inline because my mail client corrupts the
> patches with extra white space. The linked patch should meet all
> requirements listed in Submitting_Xen_Patches.
>
> Thanks,
> Philip Wernersbach

In which case I shall do a cursory review right now.

You have used tabs not spaces.  This needs fixing, and will likely fix
the alignment issues

"static acpi_physical_address __initdata global_rsdp_address;" should
not be static.  As the patch currently stands you have two static
variables with same name.

"static char __initdata global_rsdp_address_string" again shouldn't be
static

acpi_os_get_root_pointer() already a global function which does what you
want.  No need to edit drivers/acpi/tables at all.

~Andrew