From: Laszlo Ersek <lersek@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] converting pci-assign to qerror_report()?
Date: Tue, 17 Dec 2013 20:32:35 +0100 [thread overview]
Message-ID: <52B0A6D3.4030408@redhat.com> (raw)
Hi Anthony,
I'm thinking about converting the error reporting in assigned_initfn()
[hw/i386/kvm/pci-assign.c] from error_report() to qerror_report[_err]().
Internally I might use error propagation, but I don't intend to convert
pci-assign from qdev to QOM / true realizefn. (I intend to *re*-try
error propagation up to and thru device_add even less.) So internal
errors wouldn't propagate out of assigned_initfn(), I'd probably consume
them there with qerror_report_err().
Considering your earlier message
https://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg03102.html
will you NAK such a patch?
(I'll note that this is not a *new* QMP function.)
Thanks!
Laszlo
reply other threads:[~2013-12-17 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B0A6D3.4030408@redhat.com \
--to=lersek@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.