From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Vt2uZ-0000Ct-1S
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 17:14:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Vt2uT-0001YS-2T
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 17:14:42 -0500
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:57592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Vt2uS-0001YO-Sb
	for qemu-devel@nongnu.org; Tue, 17 Dec 2013 17:14:36 -0500
Message-ID: <52B0CCC8.700@weilnetz.de>
Date: Tue, 17 Dec 2013 23:14:32 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <3c36242e55b6cb881ce8db1d67283a8358d96f17.1387306432.git.jcody@redhat.com>
In-Reply-To: <3c36242e55b6cb881ce8db1d67283a8358d96f17.1387306432.git.jcody@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qemu-kvm PATCH v2] docs: updated qemu-img man
 page and qemu-doc to reflect VHDX support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

Am 17.12.2013 19:56, schrieb Jeff Cody:
> The man page for qemu-img, and the qemu-doc, did not mention VHDX
> as a supported format.  This adds in reference to VHDX in those
> documents.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  qemu-doc.texi | 15 +++++++++++++++
>  qemu-img.texi |  4 ++--
>  2 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 185dd47..f9f11ae 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -654,6 +654,21 @@ Supported options:
>  Specifies which VHD subformat to use. Valid options are
>  @code{dynamic} (default) and @code{fixed}.
>  @end table
> +
> +@item VHDX
> +Hyper-V compatible image format (VHDX).
> +Supported options:
> +@table @code
> +@item subformat
> +Specifies which VHDX subformat to use. Valid options are
> +@code{dynamic} (default) and @code{fixed}.
> +@item block_state_zero
> +Force use of payload blocks of type 'ZERO'.
> +@item block_size
> +Block Size; min 1 MB, max 256 MB.  0 means auto-calculate based on image size.

s/Size/size/ (can be fixed by Kevin or Stefan, no need for a v3 patch)

> +@item log_size
> +Log size; min 1 MB.
> +@end table
>  @end table
>  
>  @subsubsection Read-only formats
> diff --git a/qemu-img.texi b/qemu-img.texi
> index be31191..1bba91e 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -431,8 +431,8 @@ This option can only be enabled if @code{compat=1.1} is specified.
>  
>  @item Other
>  QEMU also supports various other image file formats for compatibility with
> -older QEMU versions or other hypervisors, including VMDK, VDI, VHD (vpc), qcow1
> -and QED. For a full list of supported formats see @code{qemu-img --help}.
> +older QEMU versions or other hypervisors, including VMDK, VDI, VHD (vpc), VHDX,
> +qcow1 and QED. For a full list of supported formats see @code{qemu-img --help}.
>  For a more detailed description of these formats, see the QEMU Emulation User
>  Documentation.

Reviewed-by: Stefan Weil <sw@weilnetz.de>