From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy Date: Wed, 18 Dec 2013 10:09:34 +0800 Message-ID: <52B103DE.7090604@cn.fujitsu.com> References: <1387182666-31301-1-git-send-email-roy.qing.li@gmail.com> <52AFC43C.9080804@cn.fujitsu.com> <52AFE7E3.3070806@cn.fujitsu.com> <20131217070231.GA11970@order.stressinduktion.org> <52B00150.3070002@cn.fujitsu.com> <20131217134823.GC18396@order.stressinduktion.org> <52B0F0C4.1010803@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Hannes Frederic Sowa , netdev@vger.kernel.org To: RongQing Li Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:21166 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752235Ab3LRCIr (ORCPT ); Tue, 17 Dec 2013 21:08:47 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 12/18/2013 09:58 AM, RongQing Li wrote: > On Wed, Dec 18, 2013 at 8:48 AM, Gao feng wrote: >> On 12/17/2013 09:48 PM, Hannes Frederic Sowa wrote: >>> On Tue, Dec 17, 2013 at 03:46:24PM +0800, Gao feng wrote: >>>> The from of new cloned rt should not be set if it's impossible for the ort >>>> to be expired. >>> >>> Actually, why do you think so? What could go wrong? >>> >> >> I just don't want rt6_check_expired to check some impossible expired routes. >> > > What is wrong if we set from for new cloned rt by checking if ort has > RTF_EXPIRES flag? The RTF_EXPIRES flag may be changed by router advertisment package, the ort may become expired after you hadn't set from for new cloned rt. we should set from even this kind of ort doesn't have RTF_EXPIRES flag.