All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <hui.geng@huawei.com>,
	Wang Guoli <andy.wangguoli@huawei.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] jffs2: unlock f->sem on error in jffs2_new_inode()
Date: Wed, 18 Dec 2013 10:39:03 +0800	[thread overview]
Message-ID: <52B10AC7.4080107@huawei.com> (raw)
In-Reply-To: <1387332894-33977-1-git-send-email-wangnan0@huawei.com>

The patch should be sent to jffs2 mainling list, which is
linux-mtd@lists.infradead.org.

It's not needed to cc stable mailing list. Actually I think it's
better not to.

On 2013/12/18 10:14, Wang Nan wrote:
> From: Wang Guoli <andy.wangguoli@huawei.com>
> 
> If jffs2_new_inode() succeeds, it returns with f->sem held, and
> the caller is responsible for releasing the lock. If it fails,
> it still returns with the lock held, but the caller won't release
> the lock, which will lead to deadlock.
> 
> Fix it by releasing the lock in jffs2_new_inode() on error.
> 
> Cc: <stable@vger.kernel.org> # 2.6.34+
> Signed-off-by: Wang Guoli <andy.wangguoli@huawei.com>

You should also sign the patch.

> ---
>  fs/jffs2/fs.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)


  reply	other threads:[~2013-12-18  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  2:14 [PATCH] jffs2: unlock f->sem on error in jffs2_new_inode() Wang Nan
2013-12-18  2:39 ` Li Zefan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-12-18  3:05 Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B10AC7.4080107@huawei.com \
    --to=lizefan@huawei.com \
    --cc=andy.wangguoli@huawei.com \
    --cc=hui.geng@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.