From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH net-next v2 0/6] slight optimization of addr compare for some modules Date: Wed, 18 Dec 2013 16:47:26 +0800 Message-ID: <52B1611E.4090608@huawei.com> References: <52AEB8B3.5010405@huawei.com> <1387205111.18217.7.camel@joe-AO722> <52AF13F4.5040409@gmail.com> <1387207006.18217.28.camel@joe-AO722> <1387214748.18217.52.camel@joe-AO722> <52AFAFDC.2080807@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Netdev To: Joe Perches , Ding Tianhong Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:63624 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905Ab3LRJAP (ORCPT ); Wed, 18 Dec 2013 04:00:15 -0500 In-Reply-To: <52AFAFDC.2080807@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2013/12/17 9:58, Ding Tianhong wrote: > On 2013/12/17 1:25, Joe Perches wrote: >> Hi again Ding. >> >> These should still be inspected for appropriate use of >> ether_addr_equal or ether_addr_equal_unaligned, but a >> better cocci input sp-file is: >> >> $ cat ether_addr_equal_unaligned.cocci >> @@ >> expression e1; >> expression e2; >> @@ >> >> - !memcmp(e1, e2, \(6\|ETH_ALEN\)) >> + ether_addr_equal_unaligned(e1, e2) >> >> @@ >> expression e1; >> expression e2; >> @@ >> >> - memcmp(e1, e2, \(6\|ETH_ALEN\)) == 0 >> + ether_addr_equal_unaligned(e1, e2) >> >> @@ >> expression e1; >> expression e2; >> @@ >> >> - memcmp(e1, e2, \(6\|ETH_ALEN\)) >> + !ether_addr_equal_unaligned(e1, e2) >> >> @@ >> expression e1; >> expression e2; >> @@ >> >> - memcmp(e1, e2, \(6\|ETH_ALEN\)) != 0 >> + !ether_addr_equal_unaligned(e1, e2) >> >> >> > > great, thanks, I 'll try and test. > > Regards > ding > Hi Joe: There are too many places need to be changed, should I make it in one patch or several pathset, pls give me some advise. thanks Regards Ding >> >