From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Date: Wed, 18 Dec 2013 09:20:32 +0000 Subject: [PATCH net-next 2/3] sctp: remove the never used 'return' and, redundant 'break' Message-Id: <52B168E0.1060108@huawei.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller , Vlad Yasevich , Neil Horman Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org In switch() had do return, and never use the 'return NULL'. The 'break' after return or goto has no effect. Remove it. Signed-off-by: Wang Weidong --- net/sctp/input.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/sctp/input.c b/net/sctp/input.c index 2a192a7..c956dc9 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1120,15 +1120,10 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net, case SCTP_CID_INIT: case SCTP_CID_INIT_ACK: return __sctp_rcv_init_lookup(net, skb, laddr, transportp); - break; default: return __sctp_rcv_walk_lookup(net, skb, laddr, transportp); - break; } - - - return NULL; } /* Lookup an association for an inbound skb. */ -- 1.7.12 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Subject: [PATCH net-next 2/3] sctp: remove the never used 'return' and, redundant 'break' Date: Wed, 18 Dec 2013 17:20:32 +0800 Message-ID: <52B168E0.1060108@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , To: David Miller , Vlad Yasevich , Neil Horman Return-path: Received: from szxga03-in.huawei.com ([119.145.14.66]:17286 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab3LRJVj (ORCPT ); Wed, 18 Dec 2013 04:21:39 -0500 Sender: netdev-owner@vger.kernel.org List-ID: In switch() had do return, and never use the 'return NULL'. The 'break' after return or goto has no effect. Remove it. Signed-off-by: Wang Weidong --- net/sctp/input.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/sctp/input.c b/net/sctp/input.c index 2a192a7..c956dc9 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1120,15 +1120,10 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net, case SCTP_CID_INIT: case SCTP_CID_INIT_ACK: return __sctp_rcv_init_lookup(net, skb, laddr, transportp); - break; default: return __sctp_rcv_walk_lookup(net, skb, laddr, transportp); - break; } - - - return NULL; } /* Lookup an association for an inbound skb. */ -- 1.7.12