All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	Miroslav Rezanina <mrezanin@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output
Date: Wed, 18 Dec 2013 11:39:56 +0100	[thread overview]
Message-ID: <52B17B7C.5090702@redhat.com> (raw)
In-Reply-To: <1386182548-27119-1-git-send-email-ehabkost@redhat.com>

Il 04/12/2013 19:42, Eduardo Habkost ha scritto:
> Bugzilla: 972773
> Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272
> 
> Add support statement to -help output, reporting direct qemu-kvm usage
> as unsupported by Red Hat, and advising users to use libvirt instead.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 9b1738b..fdc8c65 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1995,9 +1995,17 @@ static void version(void)
>      printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
>  }
>  
> +static void print_rh_warning(void)
> +{
> +    printf("\nWARNING: Direct use of qemu-kvm from the command line is not supported by Red Hat.\n"
> +             "WARNING: Use libvirt as the stable management interface.\n"
> +             "WARNING: Some command line options listed here may not be available in future releases.\n\n");
> +}
> +
>  static void help(int exitcode)
>  {
>      version();
> +    print_rh_warning();
>      printf("usage: %s [options] [disk_image]\n\n"
>             "'disk_image' is a raw hard disk image for IDE hard disk 0\n\n",
>              error_get_progname());
> @@ -2012,6 +2020,7 @@ static void help(int exitcode)
>             "\n"
>             "When using -nographic, press 'ctrl-a h' to get some help.\n");
>  
> +    print_rh_warning();
>      exit(exitcode);
>  }
>  
> 

Wow, no whitelist anymore?!?!?

ACK

Paolo

      parent reply	other threads:[~2013-12-18 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 18:42 [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output Eduardo Habkost
2013-12-04 18:51 ` Eric Blake
2013-12-04 18:53   ` Eduardo Habkost
2013-12-18 10:39 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B17B7C.5090702@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.