From: emilio@elopez.com.ar (Emilio López)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/11] clk: sunxi: make factors_clk_setup return the clock it registers
Date: Wed, 18 Dec 2013 08:34:43 -0300 [thread overview]
Message-ID: <52B18853.1000301@elopez.com.ar> (raw)
In-Reply-To: <20131218030140.23538.40290@quantum>
Hi Mike,
El 18/12/13 00:01, Mike Turquette escribi?:
> Quoting Emilio L?pez (2013-12-17 16:44:56)
>> We will be needing this to register a factor clock as parent with leaf
>> divisors on a single call. While at it, also prepare the function to set
>> the ignore flag on pll5, so our RAM keeps working.
>>
>> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
>> ---
(...)
>>
>> + /* We should not disable pll5, it powers the RAM */
>> + flags = !strcmp("pll5", clk_name) ? CLK_IGNORE_UNUSED : 0;
>
> For hardware-agnostic flags like CLK_IGNORE_UNUSED I think that we can
> add a property to the binding description instead of hard-coding a
> string name in here.
Hm, I don't know if something like that would really belong to the DT.
In any case, I should be able to drop this from here now that the clock
protection stuff is in place, so it should be a non-issue.
> Rest of the patch looks good to me. Ack.
Thanks for reviewing this!
Emilio
next prev parent reply other threads:[~2013-12-18 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 0:44 [PATCH v2 00/11] clk: sunxi: PLL4/5/6, mod0 and mbus support Emilio López
2013-12-18 0:44 ` [PATCH v2 01/11] clk: sunxi: register factors clocks behind composite Emilio López
2013-12-18 2:55 ` Mike Turquette
2013-12-18 11:27 ` Emilio López
2013-12-18 0:44 ` [PATCH v2 02/11] clk: sunxi: add gating support to PLL1 Emilio López
2013-12-18 2:57 ` Mike Turquette
2013-12-18 0:44 ` [PATCH v2 03/11] ARM: sunxi: add PLL4 support Emilio López
2013-12-18 0:44 ` [PATCH v2 04/11] clk: sunxi: make factors_clk_setup return the clock it registers Emilio López
2013-12-18 3:01 ` Mike Turquette
2013-12-18 11:34 ` Emilio López [this message]
2013-12-18 0:44 ` [PATCH v2 05/11] clk: sunxi: add PLL5 and PLL6 support Emilio López
2013-12-19 4:59 ` Mike Turquette
2013-12-21 2:26 ` Emilio López
2013-12-18 0:44 ` [PATCH v2 06/11] ARM: " Emilio López
2013-12-18 0:44 ` [PATCH v2 07/11] clk: sunxi: mod0 support Emilio López
2013-12-19 4:59 ` Mike Turquette
2013-12-18 0:45 ` [PATCH v2 08/11] ARM: sun4i: dt: mod0 clocks Emilio López
2013-12-18 9:48 ` Maxime Ripard
2013-12-18 11:40 ` Emilio López
2013-12-18 0:45 ` [PATCH v2 09/11] ARM: sun5i: " Emilio López
2013-12-18 0:45 ` [PATCH v2 10/11] ARM: sun7i: " Emilio López
2013-12-18 0:45 ` [PATCH v2 11/11] ARM: sunxi: dt: add nodes for the mbus clock Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B18853.1000301@elopez.com.ar \
--to=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.