From: Gal Hammer <ghammer@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V4] char: restore read callback on a reattached (hotplug) chardev
Date: Wed, 18 Dec 2013 16:14:41 +0200 [thread overview]
Message-ID: <52B1ADD1.7050509@redhat.com> (raw)
In-Reply-To: <20131218053547.GB22209@grmbl.mre>
On 18/12/2013 07:35, Amit Shah wrote:
>> As far as I could tell the pty backend doesn't suffer from this
>> issue. That's why I didn't change anything there.
>
> pty_chr_update_read_handler() calls pty_chr_state(), which calls
> remove_fd_in_watch().
Yes, but the pty_chr_update_read_handler() isn't called on device
removal so remove_fd_in_watch() is not executed.
However I did find that there was a problem in the pty backend that I
missed and I'll post an updated patch.
Thanks,
Gal.
prev parent reply other threads:[~2013-12-18 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 10:26 [Qemu-devel] [PATCH V4] char: restore read callback on a reattached (hotplug) chardev Gal Hammer
2013-12-16 20:32 ` Amit Shah
2013-12-17 9:12 ` Gal Hammer
2013-12-18 5:35 ` Amit Shah
2013-12-18 14:14 ` Gal Hammer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B1ADD1.7050509@redhat.com \
--to=ghammer@redhat.com \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.