From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtJDE-0000fN-UU
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 10:39:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtJD7-0000Ph-Kh
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 10:39:04 -0500
Received: from cantor2.suse.de ([195.135.220.15]:40584 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtJD7-0000Pc-F3
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 10:38:57 -0500
Message-ID: <52B1C18C.6080105@suse.de>
Date: Wed, 18 Dec 2013 16:38:52 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1384941320-30987-1-git-send-email-armbru@redhat.com>
	<8738lqgqf1.fsf@blackfin.pond.sub.org>
In-Reply-To: <8738lqgqf1.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of
	qdevification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>

I had a brief look at this series. Dropping redundant fields certainly
sounds good and after the lengthy QOM'ifications of IDE devices we seem
to no longer break any devices, but whether to check for device or
BlockDriverState sounds more like a block topic to me...

Regards,
Andreas

Am 18.12.2013 15:54, schrieb Markus Armbruster:
> Ping?
>=20
> armbru@redhat.com writes:
>=20
>> From: Markus Armbruster <armbru@redhat.com>
>>
>> Obvious cleanups possible since we no longer have the special case of
>> a non-qdevified controller.
>>
>> v2:
>> * Dropped PATCH 1/10 ide: Break all non-qdevified controllers
>>   Andreas qdevified them since; thanks!
>> * Series renamed from "Drop code for non-qdevified IDE, and clean up"
>> * Trivially rebased
>>
>> Markus Armbruster (9):
>>   ide: Move IDEDevice pointer from IDEBus to IDEState
>>   ide: Use IDEState member dev for "device connected" test
>>   ide: Don't block-align IDEState member smart_selftest_data
>>   ide: Drop redundant IDEState member bs
>>   ide: Drop redundant IDEState geometry members
>>   ide: Drop redundant IDEState member version
>>   ide: Drop redundant IDEState member drive_serial_str
>>   ide: Drop redundant IDEState member model
>>   ide: Drop redundant IDEState member wwn
>>
>>  hw/ide/ahci.c       |  19 +++--
>>  hw/ide/atapi.c      |  39 +++++----
>>  hw/ide/core.c       | 235 +++++++++++++++++++++++--------------------=
---------
>>  hw/ide/internal.h   |  15 +---
>>  hw/ide/macio.c      |  26 +++---
>>  hw/ide/microdrive.c |   2 +-
>>  hw/ide/piix.c       |   4 -
>>  hw/ide/qdev.c       |  50 ++++++-----
>>  8 files changed, 181 insertions(+), 209 deletions(-)


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg