From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbaron@akamai.com (Jason Baron) Date: Wed, 18 Dec 2013 10:55:42 -0500 Subject: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability In-Reply-To: <52AD8E10.2010904@gmail.com> References: <1386691433-6827-1-git-send-email-liuj97@gmail.com> <1386691433-6827-8-git-send-email-liuj97@gmail.com> <20131213112019.751f7946@gandalf.local.home> <52AD8E10.2010904@gmail.com> Message-ID: <52B1C57E.7000901@akamai.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/15/2013 06:10 AM, Jiang Liu wrote: > On 12/14/2013 12:20 AM, Steven Rostedt wrote: >> On Wed, 11 Dec 2013 00:03:53 +0800 >> Jiang Liu wrote: >> >>> Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better >>> readability. >> Looks good, just a little nit. (see below) >> >>> Signed-off-by: Jiang Liu >>> --- >>> include/linux/jump_label.h | 15 ++++++++++----- > ... >>> @@ -123,9 +126,11 @@ extern void static_key_slow_dec(struct static_key *key); >>> extern void jump_label_apply_nops(struct module *mod); >>> >>> #define STATIC_KEY_INIT_TRUE ((struct static_key) \ >>> - { .enabled = ATOMIC_INIT(1), .entries = (void *)1 }) >>> + { .enabled = ATOMIC_INIT(1), \ >>> + .entries = (void *)JUMP_LABEL_TYPE_TRUE_BRANCH }) >>> #define STATIC_KEY_INIT_FALSE ((struct static_key) \ >>> - { .enabled = ATOMIC_INIT(0), .entries = (void *)0 }) >>> + { .enabled = ATOMIC_INIT(0), \ >>> + .entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH }) >> Can we prettify the backslashes like: >> >> #define STATIC_KEY_INIT_TRUE ((struct static_key) \ >> { .enabled = ATOMIC_INIT(1), \ >> .entries = (void *)JUMP_LABEL_TYPE_TRUE_BRANCH }) >> #define STATIC_KEY_INIT_FALSE ((struct static_key) \ >> { .enabled = ATOMIC_INIT(0), \ >> .entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH }) >> >> >> Other than that. >> >> Acked-by: Steven Rostedt > Thanks Steve. > Will make this change. Works for me too, feel free to add: Acked-by: Jason Baron Thanks, -Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754474Ab3LRPzp (ORCPT ); Wed, 18 Dec 2013 10:55:45 -0500 Received: from prod-mail-xrelay07.akamai.com ([72.246.2.115]:29320 "EHLO prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070Ab3LRPzo (ORCPT ); Wed, 18 Dec 2013 10:55:44 -0500 Message-ID: <52B1C57E.7000901@akamai.com> Date: Wed, 18 Dec 2013 10:55:42 -0500 From: Jason Baron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Jiang Liu , Steven Rostedt CC: Catalin Marinas , Will Deacon , Sandeepa Prabhu , AKASHI Takahiro , Andrew Morton , Hannes Frederic Sowa , Andrew Jones , "David S. Miller" , Konrad Rzeszutek Wilk , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability References: <1386691433-6827-1-git-send-email-liuj97@gmail.com> <1386691433-6827-8-git-send-email-liuj97@gmail.com> <20131213112019.751f7946@gandalf.local.home> <52AD8E10.2010904@gmail.com> In-Reply-To: <52AD8E10.2010904@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2013 06:10 AM, Jiang Liu wrote: > On 12/14/2013 12:20 AM, Steven Rostedt wrote: >> On Wed, 11 Dec 2013 00:03:53 +0800 >> Jiang Liu wrote: >> >>> Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better >>> readability. >> Looks good, just a little nit. (see below) >> >>> Signed-off-by: Jiang Liu >>> --- >>> include/linux/jump_label.h | 15 ++++++++++----- > ... >>> @@ -123,9 +126,11 @@ extern void static_key_slow_dec(struct static_key *key); >>> extern void jump_label_apply_nops(struct module *mod); >>> >>> #define STATIC_KEY_INIT_TRUE ((struct static_key) \ >>> - { .enabled = ATOMIC_INIT(1), .entries = (void *)1 }) >>> + { .enabled = ATOMIC_INIT(1), \ >>> + .entries = (void *)JUMP_LABEL_TYPE_TRUE_BRANCH }) >>> #define STATIC_KEY_INIT_FALSE ((struct static_key) \ >>> - { .enabled = ATOMIC_INIT(0), .entries = (void *)0 }) >>> + { .enabled = ATOMIC_INIT(0), \ >>> + .entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH }) >> Can we prettify the backslashes like: >> >> #define STATIC_KEY_INIT_TRUE ((struct static_key) \ >> { .enabled = ATOMIC_INIT(1), \ >> .entries = (void *)JUMP_LABEL_TYPE_TRUE_BRANCH }) >> #define STATIC_KEY_INIT_FALSE ((struct static_key) \ >> { .enabled = ATOMIC_INIT(0), \ >> .entries = (void *)JUMP_LABEL_TYPE_FALSE_BRANCH }) >> >> >> Other than that. >> >> Acked-by: Steven Rostedt > Thanks Steve. > Will make this change. Works for me too, feel free to add: Acked-by: Jason Baron Thanks, -Jason