From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtJuE-00019s-8T for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:23:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtJu8-00064g-AQ for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:23:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtJu8-00064W-2t for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:23:24 -0500 Message-ID: <52B1C684.5020803@redhat.com> Date: Wed, 18 Dec 2013 17:00:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386753670-11238-1-git-send-email-ghammer@redhat.com> <52B1AFC3.1050809@redhat.com> <52B1C654.2070308@redhat.com> In-Reply-To: <52B1C654.2070308@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer Cc: "seabios@seabios.org" , qemu-devel@nongnu.org, "Michael S. Tsirkin" Il 18/12/2013 16:59, Gal Hammer ha scritto: >> >> Note this is not the APIC base address, that one is 80h on the ISA >> bridge (function 0). You're changing the behavior for 80h on the powe= r >> management function, which is function 3. The register is "PMBA=97POW= ER >> MANAGEMENT BASE ADDRESS" and it is indeed initialized by SeaBIOS in >> piix4_pm_setup (src/fw/pciinit.c). >=20 > I think we both made a mistake and the right name is > "PMREGMISC=97MISCELLANEOUS POWER MANAGEMENT (FUNCTION 3)" :-). Yeah. :) Still, both PMBA and PMREGMISC need to be initialized by SeaBIO= S. Paolo