From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK44-0006yj-17 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:33:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtK3v-0000dP-Vf for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:33:39 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42138 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK3v-0000dL-Pm for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:33:31 -0500 Message-ID: <52B1CE57.1030705@suse.de> Date: Wed, 18 Dec 2013 17:33:27 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387383351-24121-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1387383351-24121-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Markus Armbruster Am 18.12.2013 17:15, schrieb Stefan Hajnoczi: > Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8 > ("qdev: Drop misleading qdev_free() function"). The qbus_free() > function removes the child from the namespace and decrements the > reference count. It does not, however, guarantee to free the child > since the refcount may still be held. >=20 > Just call object_unparent() directly. >=20 > Suggested-by: Markus Armbruster > Signed-off-by: Stefan Hajnoczi Thanks, nice and trivial, applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg