From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH] ARM: dts: Add SPI nodes to the exynos5420 device tree file Date: Thu, 19 Dec 2013 02:37:07 +0900 Message-ID: <52B1DD43.9020401@samsung.com> References: <1377856637-7595-1-git-send-email-l.krishna@samsung.com> <086701cedf98$ab9d9f60$02d8de20$@org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:34764 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718Ab3LRRhR (ORCPT ); Wed, 18 Dec 2013 12:37:17 -0500 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Leela Krishna Amudala Cc: Kukjin Kim , linux-samsung-soc , devicetree@vger.kernel.org, Douglas Anderson , abrestic@chromium.org, Tomasz Figa On 12/12/13 20:34, Leela Krishna Amudala wrote: > Hi Kukjin, > > Can you kindly look into this patch and take necessary action..? > > Best Wishes, > Leela Krishna. > > On Tue, Nov 12, 2013 at 9:02 PM, Leela Krishna Amudala > wrote: >> Hi Kukjin, >> >> Thanks for reviewing the patch. >> >> On Tue, Nov 12, 2013 at 4:46 PM, Kukjin Kim wrote: >>> Leela Krishna Amudala wrote: >>>> >>>> Add SPI device tree nodes to Exynos5420 SoC >>>> >>>> Signed-off-by: Doug Anderson >>>> Signed-off-by: Leela Krishna Amudala >>>> Reviewed-by: Andrew Bresticker >>>> --- >>>> Note: This patch is rebased on Kgene's for-next branch and is dependent on >>>> [V3] ARM: dts: Add DMA controller node info on Exynos5420. >>>> https://patchwork.kernel.org/patch/2851790/ >>>> >>>> arch/arm/boot/dts/exynos5420.dtsi | 51 >>>> +++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 51 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >>>> b/arch/arm/boot/dts/exynos5420.dtsi >>>> index 15465f8..8d9e980 100644 >>>> --- a/arch/arm/boot/dts/exynos5420.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi >>>> @@ -27,6 +27,9 @@ >>>> pinctrl2 =&pinctrl_2; >>>> pinctrl3 =&pinctrl_3; >>>> pinctrl4 =&pinctrl_4; >>>> + spi0 =&spi_0; >>>> + spi1 =&spi_1; >>>> + spi2 =&spi_2; >>>> }; >>>> >>>> cpus { >>>> @@ -238,6 +241,54 @@ >>>> }; >>>> }; >>>> >>>> + spi_0: spi@12d20000 { >>>> + compatible = "samsung,exynos4210-spi"; >>>> + reg =<0x12d20000 0x100>; >>>> + interrupts =<0 66 0>; >>>> + dmas =<&pdma0 5 >>>> +&pdma0 4>; >>>> + dma-names = "tx", "rx"; >>>> + #address-cells =<1>; >>>> + #size-cells =<0>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 =<&spi0_bus>; >>>> + clocks =<&clock 271>,<&clock 135>; >>>> + clock-names = "spi", "spi_busclk0"; >>>> + status = "disabled"; >>>> + }; >>>> + >>>> + spi_1: spi@12d30000 { >>>> + compatible = "samsung,exynos4210-spi"; >>>> + reg =<0x12d30000 0x100>; >>>> + interrupts =<0 67 0>; >>>> + dmas =<&pdma1 5 >>>> +&pdma1 4>; >>>> + dma-names = "tx", "rx"; >>>> + #address-cells =<1>; >>>> + #size-cells =<0>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 =<&spi1_bus>; >>>> + clocks =<&clock 272>,<&clock 136>; >>>> + clock-names = "spi", "spi_busclk0"; >>>> + status = "disabled"; >>>> + }; >>>> + >>>> + spi_2: spi@12d40000 { >>>> + compatible = "samsung,exynos4210-spi"; >>>> + reg =<0x12d40000 0x100>; >>>> + interrupts =<0 68 0>; >>>> + dmas =<&pdma0 7 >>>> +&pdma0 6>; >>>> + dma-names = "tx", "rx"; >>>> + #address-cells =<1>; >>>> + #size-cells =<0>; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 =<&spi2_bus>; >>>> + clocks =<&clock 273>,<&clock 137>; >>>> + clock-names = "spi", "spi_busclk0"; >>>> + status = "disabled"; >>>> + }; >>>> + >>>> serial@12C00000 { >>>> clocks =<&clock 257>,<&clock 128>; >>>> clock-names = "uart", "clk_uart_baud0"; >>>> -- >>>> 1.7.10.4 >>> >>> Leela, do you still want to keep the status 'disabled' for SPIs? >>> >> >> Yes, the SPI client nodes will make status = "okay" in board file. >> OK, applied. Thanks, Kukjin