From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45784)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtLXr-0002br-Eq
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 13:08:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtLXl-0006N0-JI
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 13:08:31 -0500
Received: from cantor2.suse.de ([195.135.220.15]:43955 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtLXl-0006Mv-Cd
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 13:08:25 -0500
Message-ID: <52B1E494.7080404@suse.de>
Date: Wed, 18 Dec 2013 19:08:20 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1383646565-13774-1-git-send-email-zxq_yx_007@163.com>
	<52B1E202.4070701@suse.de>
In-Reply-To: <52B1E202.4070701@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: xiaoqiang zhao <zxq_yx_007@163.com>, qemu-devel@nongnu.org
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>, pbonzini@redhat.com, Stefano Stabellini <stefano.stabellini@citrix.com>, aliguori@amazon.com

Am 18.12.2013 18:57, schrieb Andreas F=E4rber:
> Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
>> xiaoqiang zhao (4):
>>   apic: Cleanup for QOM'ify
>>   apic: QOM'ify apic & icc_bus
>>   ioapic: Cleanup for QOM'ify
>>   ioapic: QOM'ify ioapic
>=20
> Thanks, I have rebased and queued them with changes on qom-next:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
>=20
> In particular I have reverted TYPE_ introductions were unnecessary and
> reverted usages of TYPE_ constants for MemoryRegions. Also two white
> lines have been dropped. The ICC bus conversion has been split out as a
> separate step, using NULL errp as intermediate step since ignored.
> (CC'ing Peter C. and Luiz)

Oh and you forgot to convert the Xen APIC, I trivially fixed that.
(CC'ing Stefano)

>=20
> However I still have doubts about the last patch and would appreciate
> feedback from Paolo, Anthony or anyone, cf. upcoming reply there.
>=20
> Regards,
> Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg